Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java

Issue 2865463003: Tracks GVR version crossed with headset type using UMA. (Closed)
Patch Set: Fixed comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java
index e6f6fbf40606a6b87d8a87776dc8e61369365b55..46852a75a2453bf69ad4c30dee8914eefb31541e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java
@@ -4,29 +4,16 @@
package org.chromium.chrome.browser.vr_shell;
-import android.support.annotation.IntDef;
-
-import java.lang.annotation.Retention;
-import java.lang.annotation.RetentionPolicy;
-
/**
* Abstracts away the VrCoreVersionCheckerImpl class, which may or may not be present at runtime
* depending on compile flags.
*/
public interface VrCoreVersionChecker {
- public static final int VR_NOT_SUPPORTED = 0;
- public static final int VR_NOT_AVAILABLE = 1;
- public static final int VR_OUT_OF_DATE = 2;
- public static final int VR_READY = 3;
-
- @Retention(RetentionPolicy.SOURCE)
- @IntDef({VR_NOT_AVAILABLE, VR_OUT_OF_DATE, VR_READY})
- public @interface VrCoreCompatibility {}
-
public static final String VR_CORE_PACKAGE_ID = "com.google.vr.vrcore";
/**
- * Check if VrCore is installed or if installed version is compatible with Chromium.
+ * Returns the version of VrCore (if it is installed) and the compatibility of VrCore with
+ * Chrome.
*/
- int getVrCoreCompatibility();
+ VrCoreInfo getVrCoreInfo();
}

Powered by Google App Engine
This is Rietveld 408576698