Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: third_party/WebKit/Source/platform/loader/fetch/RawResource.cpp

Issue 2845513002: [WIP] Add Resource::IsShareable
Patch Set: fix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/loader/fetch/RawResource.cpp
diff --git a/third_party/WebKit/Source/platform/loader/fetch/RawResource.cpp b/third_party/WebKit/Source/platform/loader/fetch/RawResource.cpp
index cc24996010f0da0e8ec819e3457404de7eed8215..d1c47d3302f49efaddb727ee4879c7af03202845 100644
--- a/third_party/WebKit/Source/platform/loader/fetch/RawResource.cpp
+++ b/third_party/WebKit/Source/platform/loader/fetch/RawResource.cpp
@@ -28,7 +28,6 @@
#include <memory>
#include "platform/HTTPNames.h"
#include "platform/loader/fetch/FetchParameters.h"
-#include "platform/loader/fetch/MemoryCache.h"
#include "platform/loader/fetch/ResourceClientWalker.h"
#include "platform/loader/fetch/ResourceFetcher.h"
#include "platform/loader/fetch/ResourceLoader.h"
@@ -183,16 +182,6 @@ void RawResource::WillNotFollowRedirect() {
void RawResource::ResponseReceived(
const ResourceResponse& response,
std::unique_ptr<WebDataConsumerHandle> handle) {
- if (response.WasFallbackRequiredByServiceWorker()) {
- // The ServiceWorker asked us to re-fetch the request. This resource must
- // not be reused.
- // Note: This logic is needed here because DocumentThreadableLoader handles
- // CORS independently from ResourceLoader. Fix it.
- GetMemoryCache()->Remove(this);
- }
-
- bool is_successful_revalidation =
- IsCacheValidator() && response.HttpStatusCode() == 304;
Resource::ResponseReceived(response, nullptr);
ResourceClientWalker<RawResourceClient> w(Clients());
@@ -202,15 +191,6 @@ void RawResource::ResponseReceived(
// is null when there are two or more clients, as asserted.
c->ResponseReceived(this, this->GetResponse(), std::move(handle));
}
-
- // If we successfully revalidated, we won't get appendData() calls. Forward
- // the data to clients now instead. Note: |m_data| can be null when no data is
- // appended to the original resource.
- if (is_successful_revalidation && Data()) {
- ResourceClientWalker<RawResourceClient> w(Clients());
- while (RawResourceClient* c = w.Next())
- c->DataReceived(this, Data()->Data(), Data()->size());
- }
}
void RawResource::SetSerializedCachedMetadata(const char* data, size_t size) {

Powered by Google App Engine
This is Rietveld 408576698