Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 2833073003: v8binding: Enables xss-DENIED-window-name-navigator. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by Yuki
Modified:
2 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

v8binding: Enables xss-DENIED-window-name-navigator. Enables xss-DENIED-window-name-navigator test again since https://crrev.com/2800053003 and https://crrev.com/2824753002 should have fixed the flakiness. https://crrev.com/2835603004 should have solved the cause of the previous revert. BUG=686470 Review-Url: https://codereview.chromium.org/2833073003 Cr-Commit-Position: refs/heads/master@{#466938} Committed: https://chromium.googlesource.com/chromium/src/+/2f773b98bf5c144b8ff81320023e548b6930f40d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
Trybot results:  win_chromium_x64_rel_ng   win_clang   win_chromium_rel_ng   win_chromium_compile_dbg_ng   mac_chromium_rel_ng   mac_chromium_compile_dbg_ng   ios-simulator   ios-simulator-xcode-clang   ios-device-xcode-clang   ios-device   linux_chromium_rel_ng   linux_chromium_tsan_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_rel_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_asan_rel_ng   chromeos_daisy_chromium_compile_only_ng   chromeos_amd64-generic_chromium_compile_only_ng   chromium_presubmit   cast_shell_linux   cast_shell_android   linux_android_rel_ng   android_n5x_swarming_rel   android_cronet   android_clang_dbg_recipe   android_compile_dbg   android_arm64_dbg_recipe   win_chromium_x64_rel_ng   win_chromium_rel_ng   win_clang   mac_chromium_rel_ng   win_chromium_compile_dbg_ng   mac_chromium_compile_dbg_ng   ios-device   ios-simulator-xcode-clang   ios-device-xcode-clang   ios-simulator   linux_chromium_tsan_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_rel_ng   chromeos_daisy_chromium_compile_only_ng   linux_chromium_asan_rel_ng   chromium_presubmit   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_android   android_n5x_swarming_rel   linux_android_rel_ng   cast_shell_linux   android_cronet   android_clang_dbg_recipe   android_arm64_dbg_recipe   android_compile_dbg 
Commit queue not available (can’t edit this change).

Messages

Total messages: 12 (8 generated)
Yuki
Could you review this CL? I think that this time will be okay...
2 months, 1 week ago (2017-04-21 11:48:59 UTC) #4
haraken
LGTM
2 months, 1 week ago (2017-04-21 11:50:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833073003/1
2 months ago (2017-04-25 09:07:11 UTC) #9
commit-bot: I haz the power
2 months ago (2017-04-25 10:12:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2f773b98bf5c144b8ff81320023e...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318