Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp

Issue 2831943002: bindings: Port bindings/core/v8 away from ToImplArray APIs. (Closed)
Patch Set: Check for exception in SerializedScriptValue Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 12 matching lines...) Expand all
23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "bindings/core/v8/ScriptPromise.h" 31 #include "bindings/core/v8/ScriptPromise.h"
32 32
33 #include "bindings/core/v8/IDLTypes.h"
34 #include "bindings/core/v8/NativeValueTraitsImpl.h"
33 #include "bindings/core/v8/ScriptFunction.h" 35 #include "bindings/core/v8/ScriptFunction.h"
34 #include "bindings/core/v8/ScriptValue.h" 36 #include "bindings/core/v8/ScriptValue.h"
35 #include "bindings/core/v8/V8Binding.h" 37 #include "bindings/core/v8/V8Binding.h"
36 #include "bindings/core/v8/V8BindingForTesting.h" 38 #include "bindings/core/v8/V8BindingForTesting.h"
37 #include "core/dom/DOMException.h" 39 #include "core/dom/DOMException.h"
38 #include "core/dom/ExceptionCode.h" 40 #include "core/dom/ExceptionCode.h"
39 #include "core/testing/NullExecutionContext.h" 41 #include "core/testing/NullExecutionContext.h"
40 #include "testing/gtest/include/gtest/gtest.h" 42 #include "testing/gtest/include/gtest/gtest.h"
41 #include "v8/include/v8.h" 43 #include "v8/include/v8.h"
42 44
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 v8::Isolate* isolate_; 85 v8::Isolate* isolate_;
84 v8::TryCatch trycatch_; 86 v8::TryCatch trycatch_;
85 }; 87 };
86 88
87 String ToString(v8::Local<v8::Context> context, const ScriptValue& value) { 89 String ToString(v8::Local<v8::Context> context, const ScriptValue& value) {
88 return ToCoreString(value.V8Value()->ToString(context).ToLocalChecked()); 90 return ToCoreString(value.V8Value()->ToString(context).ToLocalChecked());
89 } 91 }
90 92
91 Vector<String> ToStringArray(v8::Isolate* isolate, const ScriptValue& value) { 93 Vector<String> ToStringArray(v8::Isolate* isolate, const ScriptValue& value) {
92 NonThrowableExceptionState exception_state; 94 NonThrowableExceptionState exception_state;
93 return ToImplArray<Vector<String>>(value.V8Value(), 0, isolate, 95 return NativeValueTraits<IDLSequence<IDLString>>::NativeValue(
94 exception_state); 96 isolate, value.V8Value(), exception_state);
95 } 97 }
96 98
97 TEST(ScriptPromiseTest, constructFromNonPromise) { 99 TEST(ScriptPromiseTest, constructFromNonPromise) {
98 V8TestingScope scope; 100 V8TestingScope scope;
99 TryCatchScope try_catch_scope(scope.GetIsolate()); 101 TryCatchScope try_catch_scope(scope.GetIsolate());
100 ScriptPromise promise(scope.GetScriptState(), 102 ScriptPromise promise(scope.GetScriptState(),
101 v8::Undefined(scope.GetIsolate())); 103 v8::Undefined(scope.GetIsolate()));
102 ASSERT_TRUE(try_catch_scope.HasCaught()); 104 ASSERT_TRUE(try_catch_scope.HasCaught());
103 ASSERT_TRUE(promise.IsEmpty()); 105 ASSERT_TRUE(promise.IsEmpty());
104 } 106 }
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 v8::MicrotasksScope::PerformCheckpoint(scope.GetIsolate()); 362 v8::MicrotasksScope::PerformCheckpoint(scope.GetIsolate());
361 363
362 EXPECT_TRUE(on_fulfilled.IsEmpty()); 364 EXPECT_TRUE(on_fulfilled.IsEmpty());
363 EXPECT_FALSE(on_rejected.IsEmpty()); 365 EXPECT_FALSE(on_rejected.IsEmpty());
364 EXPECT_EQ("world", ToString(scope.GetContext(), on_rejected)); 366 EXPECT_EQ("world", ToString(scope.GetContext(), on_rejected));
365 } 367 }
366 368
367 } // namespace 369 } // namespace
368 370
369 } // namespace blink 371 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698