chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java - Issue 2829943002: Redirecting off-origin navigations in PWAs to CCT.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java

Issue 2829943002: Redirecting off-origin navigations in PWAs to CCT. (Closed)

Patch Set: Relaxed the WebApkIntegrationTest Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/AndroidManifest.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java

index f5856284b0b1202eda4b31c8c78fd234511d858a..46ecd9adedbd97d859847a215170789fe769ebb1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java

@@ -226,6 +226,9 @@ public class TabContextMenuItemDelegate implements ContextMenuItemDelegate {

Intent chromeIntent = new Intent(Intent.ACTION_VIEW, Uri.parse(linkUrl));

chromeIntent.setPackage(mTab.getApplicationContext().getPackageName());

chromeIntent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);

+ // For "Open in Chrome" from the context menu in FullscreenActivity we want to bypass

+ // CustomTab, and this flag ensures we open in TabbedChrome.

+ chromeIntent.putExtra(ChromeLauncherActivity.EXTRA_IS_ALLOWED_TO_RETURN_TO_PARENT, false);

boolean activityStarted = false;

if (pageUrl != null) {