Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindow.h

Issue 2826393004: v8binding: Makes Location's wrapper objects alive, really. (Closed)
Patch Set: Added a layout test. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/DOMWindow.h
diff --git a/third_party/WebKit/Source/core/frame/DOMWindow.h b/third_party/WebKit/Source/core/frame/DOMWindow.h
index 54bda6350a8a1eecef7c9324783029593e519fc0..be224d432d94bb52daf5a8b26cec359df0cde25c 100644
--- a/third_party/WebKit/Source/core/frame/DOMWindow.h
+++ b/third_party/WebKit/Source/core/frame/DOMWindow.h
@@ -5,6 +5,7 @@
#ifndef DOMWindow_h
#define DOMWindow_h
+#include "bindings/core/v8/TraceWrapperMember.h"
#include "bindings/core/v8/Transferables.h"
#include "core/CoreExport.h"
#include "core/events/EventTarget.h"
@@ -51,6 +52,8 @@ class CORE_EXPORT DOMWindow : public EventTargetWithInlineData,
// GarbageCollectedFinalized overrides:
DECLARE_VIRTUAL_TRACE();
+ DECLARE_VIRTUAL_TRACE_WRAPPERS();
+
virtual bool IsLocalDOMWindow() const = 0;
virtual bool IsRemoteDOMWindow() const = 0;
@@ -127,7 +130,7 @@ class CORE_EXPORT DOMWindow : public EventTargetWithInlineData,
// of this object.
const Member<WindowProxyManager> window_proxy_manager_;
Member<InputDeviceCapabilitiesConstants> input_capabilities_;
- mutable Member<Location> location_;
+ mutable TraceWrapperMember<Location> location_;
// Set to true when close() has been called. Needed for
// |window.closed| determinism; having it return 'true'

Powered by Google App Engine
This is Rietveld 408576698