third_party/WebKit/LayoutTests/bindings/location-lifetime.html - Issue 2826393004: v8binding: Makes Location's wrapper objects alive, really.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bindings/location-lifetime.html

Issue 2826393004: v8binding: Makes Location's wrapper objects alive, really. (Closed)

Patch Set: Added a layout test. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <iframe id="iframe-for-document.location"></iframe>

	5 <iframe id="iframe-for-window.location"></iframe>

	6 <script>

	7 test(() => {

	8 let observation;

	9 (function() {

	10 let iframe = document.getElementById("iframe-for-document.location");

	11 let location = iframe.contentDocument.location;

	12 observation = internals.observeGC(location);

	13 })();

	14 gc();

	15 assert_false(observation.wasCollected, "Location wrapper object was collected. ");

	16 }, "document.location shouldn't be collected by GC.");

	17

	18 test(() => {

	19 let observation;

	20 (function() {

	21 let iframe = document.getElementById("iframe-for-window.location");

	22 let location = iframe.contentWindow.location;

	23 observation = internals.observeGC(location);

	24 })();

	25 gc();

	26 assert_false(observation.wasCollected, "Location wrapper object was collected. ");

	27 }, "window.location shouldn't be collected by GC.");

	28 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »