Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2826313003: Worklet: Enable module script loading for main thread worklets (Closed)

Created:
3 years, 8 months ago by nhiroki
Modified:
3 years, 7 months ago
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Worklet: Enable module script loading for main thread worklets This CL enables module script loading for main thread worklets (i.e., PaintWorklet). This is not fully compatible with the spec yet. For example, "module response map" concept[1] is not implemented yet and module fetch happens every time addModule() is called. It'll be implemented by following CLs. Spec: https://drafts.css-houdini.org/worklets/#fetch-a-worklet-script DesignDoc: https://docs.google.com/document/d/1cgLcrua7H_7x_o5GlzYrAi2qt-TqTzgtOeixFAugR6g/edit?usp=sharing [1] https://drafts.css-houdini.org/worklets/#module-responses-map BUG=627945 Review-Url: https://codereview.chromium.org/2826313003 Cr-Commit-Position: refs/heads/master@{#474542} Committed: https://chromium.googlesource.com/chromium/src/+/2cab1a07df84484b5088546837ad1c5b1310c00f

Patch Set 1 #

Patch Set 2 : WIP #

Patch Set 3 : rebase #

Patch Set 4 : wip #

Patch Set 5 : rebase #

Total comments: 4

Patch Set 6 : [still WIP] address kouhei@'s review comments #

Patch Set 7 : [WIP] allow script execution #

Patch Set 8 : [WIP] fix blob url creation #

Total comments: 2

Patch Set 9 : fix blob url creation #

Patch Set 10 : rebase #

Patch Set 11 : rebase #

Patch Set 12 : rebase on csspaint/ move patch and update test expectation #

Patch Set 13 : move WorkletModuleTreeClient into its own file #

Patch Set 14 : WIP #

Patch Set 15 : add missing files #

Patch Set 16 : fix global-interface-listing-paint-worklet.html #

Patch Set 17 : move inspector/console/console-on-paint-worklet.html to http/tests/inspector/console/ #

Patch Set 18 : rebase #

Patch Set 19 : rebase #

Patch Set 20 : rebase (ready for review) #

Total comments: 4

Patch Set 21 : update comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+409 lines, -344 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/csspaint/registerPaint-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +277 lines, -277 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/resources/global-interface-listing-worklet.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +14 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Modulator.cpp View 1 2 3 4 5 6 7 8 9 2 chunks +16 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/workers/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 3 chunks +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +15 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/workers/WorkletModuleTreeClient.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/workers/WorkletModuleTreeClient.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 78 (67 generated)
kouhei (in TOK)
https://codereview.chromium.org/2826313003/diff/80001/third_party/WebKit/Source/core/dom/ModulatorImpl.cpp File third_party/WebKit/Source/core/dom/ModulatorImpl.cpp (right): https://codereview.chromium.org/2826313003/diff/80001/third_party/WebKit/Source/core/dom/ModulatorImpl.cpp#newcode26 third_party/WebKit/Source/core/dom/ModulatorImpl.cpp:26: TaskRunnerHelper::Get(TaskType::kNetworking, &execution_context), shouldn't be needed. https://codereview.chromium.org/2826313003/diff/80001/third_party/WebKit/Source/core/dom/ModulatorImpl.cpp#newcode34 third_party/WebKit/Source/core/dom/ModulatorImpl.cpp:34: task_runner_(std::move(task_runner)), Maybe ...
3 years, 7 months ago (2017-05-01 10:15:32 UTC) #6
nhiroki
Thank you! https://codereview.chromium.org/2826313003/diff/80001/third_party/WebKit/Source/core/dom/ModulatorImpl.cpp File third_party/WebKit/Source/core/dom/ModulatorImpl.cpp (right): https://codereview.chromium.org/2826313003/diff/80001/third_party/WebKit/Source/core/dom/ModulatorImpl.cpp#newcode26 third_party/WebKit/Source/core/dom/ModulatorImpl.cpp:26: TaskRunnerHelper::Get(TaskType::kNetworking, &execution_context), On 2017/05/01 10:15:32, kouhei (on ...
3 years, 7 months ago (2017-05-02 03:54:38 UTC) #10
kouhei (in TOK)
lg https://codereview.chromium.org/2826313003/diff/160001/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp File third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp (right): https://codereview.chromium.org/2826313003/diff/160001/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp#newcode124 third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp:124: } Please add a comment that Step 3-5 ...
3 years, 7 months ago (2017-05-03 05:26:42 UTC) #25
nhiroki
(STILL WIP) https://codereview.chromium.org/2826313003/diff/160001/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp File third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp (right): https://codereview.chromium.org/2826313003/diff/160001/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp#newcode124 third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp:124: } On 2017/05/03 05:26:41, kouhei (on transit) ...
3 years, 7 months ago (2017-05-09 09:19:07 UTC) #34
nhiroki
Finally, this is ready for review! PTAL, thanks!
3 years, 7 months ago (2017-05-24 06:04:35 UTC) #62
kouhei (in TOK)
lgtm https://codereview.chromium.org/2826313003/diff/390001/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp File third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp (right): https://codereview.chromium.org/2826313003/diff/390001/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp#newcode82 third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp:82: return !IsJSExecutionForbidden(); Can this ever be forbidden?
3 years, 7 months ago (2017-05-24 13:48:21 UTC) #65
kinuko
https://codereview.chromium.org/2826313003/diff/390001/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp File third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp (right): https://codereview.chromium.org/2826313003/diff/390001/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp#newcode72 third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp:72: // Step 3-5 are implemented in nit: 3-5 -> ...
3 years, 7 months ago (2017-05-24 13:57:10 UTC) #66
nhiroki
Thanks for your comments! https://codereview.chromium.org/2826313003/diff/390001/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp File third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp (right): https://codereview.chromium.org/2826313003/diff/390001/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp#newcode72 third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp:72: // Step 3-5 are implemented ...
3 years, 7 months ago (2017-05-24 14:53:12 UTC) #69
kinuko
lgtm
3 years, 7 months ago (2017-05-25 01:34:10 UTC) #72
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826313003/410001
3 years, 7 months ago (2017-05-25 03:17:46 UTC) #75
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 03:24:42 UTC) #78
Message was sent while issue was closed.
Committed patchset #21 (id:410001) as
https://chromium.googlesource.com/chromium/src/+/2cab1a07df84484b5088546837ad...

Powered by Google App Engine
This is Rietveld 408576698