Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: third_party/WebKit/Source/core/dom/DOMArrayBuffer.cpp

Issue 2826263002: Make DOMArrayBuffer::Transfer neuter v8::ArrayBuffers (Closed)
Patch Set: add test and use to_transfer Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/DOMArrayBuffer.cpp
diff --git a/third_party/WebKit/Source/core/dom/DOMArrayBuffer.cpp b/third_party/WebKit/Source/core/dom/DOMArrayBuffer.cpp
index 3b7c5bc8891aecf24714cf09105eb483e4777da5..0887f6b8c725bd32f3c1e1d6a466ca27ac1ac2ff 100644
--- a/third_party/WebKit/Source/core/dom/DOMArrayBuffer.cpp
+++ b/third_party/WebKit/Source/core/dom/DOMArrayBuffer.cpp
@@ -5,10 +5,58 @@
#include "core/dom/DOMArrayBuffer.h"
#include "bindings/core/v8/DOMDataStore.h"
+#include "bindings/core/v8/DOMWrapperWorld.h"
#include "platform/wtf/RefPtr.h"
+#include "platform/wtf/Vector.h"
namespace blink {
+static void AccumulateArrayBuffersForAllWorlds(
+ v8::Isolate* isolate,
+ DOMArrayBuffer* object,
+ Vector<v8::Local<v8::ArrayBuffer>, 4>& buffers) {
+ Vector<RefPtr<DOMWrapperWorld>> worlds;
+ DOMWrapperWorld::AllWorldsInCurrentThread(worlds);
+ for (const auto& world : worlds) {
+ v8::Local<v8::Object> wrapper = world->DomDataStore().Get(object, isolate);
+ if (!wrapper.IsEmpty())
+ buffers.push_back(v8::Local<v8::ArrayBuffer>::Cast(wrapper));
+ }
+}
+
+bool DOMArrayBuffer::IsNeuterable(v8::Isolate* isolate) {
+ Vector<v8::Local<v8::ArrayBuffer>, 4> buffer_handles;
+ v8::HandleScope handle_scope(isolate);
+ AccumulateArrayBuffersForAllWorlds(isolate, this, buffer_handles);
+
+ bool is_neuterable = true;
+ for (const auto& buffer_handle : buffer_handles)
+ is_neuterable &= buffer_handle->IsNeuterable();
+
+ return is_neuterable;
+}
+
+bool DOMArrayBuffer::Transfer(v8::Isolate* isolate,
+ WTF::ArrayBufferContents& result) {
+ DOMArrayBuffer* to_transfer = this;
+ if (!IsNeuterable(isolate)) {
+ to_transfer =
+ DOMArrayBuffer::Create(Buffer()->Data(), Buffer()->ByteLength());
+ }
+
+ if (!to_transfer->Buffer()->Transfer(result))
+ return false;
+
+ Vector<v8::Local<v8::ArrayBuffer>, 4> buffer_handles;
+ v8::HandleScope handle_scope(isolate);
+ AccumulateArrayBuffersForAllWorlds(isolate, to_transfer, buffer_handles);
+
+ for (const auto& buffer_handle : buffer_handles)
+ buffer_handle->Neuter();
+
+ return true;
+}
+
DOMArrayBuffer* DOMArrayBuffer::CreateUninitializedOrNull(
unsigned num_elements,
unsigned element_byte_size) {
« no previous file with comments | « third_party/WebKit/Source/core/dom/DOMArrayBuffer.h ('k') | third_party/WebKit/Source/core/dom/DOMArrayBufferBase.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698