Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.h

Issue 2822453003: Wrap large IndexedDB values into Blobs before writing to LevelDB. (Closed)
Patch Set: Addressed last round of feedback. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.h
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.h b/third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.h
index be93108d4d79b401af2a985c6342b55b847fcd09..83464003e624bb6532c458809934e07b009efd5c 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.h
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.h
@@ -46,8 +46,6 @@ class MODULES_EXPORT IDBOpenDBRequest final : public IDBRequest {
~IDBOpenDBRequest() override;
DECLARE_VIRTUAL_TRACE();
- using IDBRequest::EnqueueResponse;
-
void EnqueueBlocked(int64_t existing_version) override;
void EnqueueUpgradeNeeded(int64_t old_version,
std::unique_ptr<WebIDBDatabase>,
@@ -56,7 +54,6 @@ class MODULES_EXPORT IDBOpenDBRequest final : public IDBRequest {
String data_loss_message) override;
void EnqueueResponse(std::unique_ptr<WebIDBDatabase>,
const IDBDatabaseMetadata&) override;
- void EnqueueResponse(int64_t old_version) override;
// SuspendableObject
void ContextDestroyed(ExecutionContext*) final;
@@ -68,6 +65,8 @@ class MODULES_EXPORT IDBOpenDBRequest final : public IDBRequest {
DEFINE_ATTRIBUTE_EVENT_LISTENER(upgradeneeded);
protected:
+ void EnqueueResponse(int64_t old_version) override;
+
bool ShouldEnqueueEvent() const override;
// EventTarget

Powered by Google App Engine
This is Rietveld 408576698