Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2799923002: MIPS[64]: Implement fill.df, copy_u.df, copy_s.df instructions in simulator (Closed)

Created:
3 years, 8 months ago by dusan.simicic
Modified:
3 years, 7 months ago
Reviewers:
ivica.bogosavljevic, ilija.pavlovic, miran.karic, miran.karic, Ilija.Pavlovic1
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS[64]: Implement fill.df, copy_u.df, copy_s.df instructions in simulator - Increase FPUregisters_[] element size to 128b in order to support MSA regs - Add skeleton for MSA instr. decoding in mips32 and mips64 simulator - Add support for fill.df, copy_u.df and copy_s.df MSA instructions - Assembler test for fill.df, copy_u.df and copy_s.df BUG= Review-Url: https://codereview.chromium.org/2799923002 Cr-Commit-Position: refs/heads/master@{#45529} Committed: https://chromium.googlesource.com/v8/v8/+/1f06818739692786c30f67fbfeda635213489133

Patch Set 1 #

Total comments: 6

Patch Set 2 : Move constants to constants-mips[64].h #

Total comments: 2

Patch Set 3 : Rebase #

Patch Set 4 : Add additional tests #

Total comments: 3

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1709 lines, -52 lines) Patch
M src/mips/constants-mips.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/mips/disasm-mips.cc View 1 2 3 4 1 chunk +0 lines, -11 lines 0 comments Download
M src/mips/simulator-mips.h View 1 2 7 chunks +65 lines, -1 line 0 comments Download
M src/mips/simulator-mips.cc View 1 2 12 chunks +584 lines, -12 lines 0 comments Download
M src/mips64/constants-mips64.h View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M src/mips64/disasm-mips64.cc View 1 2 3 4 1 chunk +0 lines, -11 lines 0 comments Download
M src/mips64/simulator-mips64.h View 1 2 7 chunks +65 lines, -1 line 0 comments Download
M src/mips64/simulator-mips64.cc View 1 2 11 chunks +602 lines, -14 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 1 2 3 4 2 chunks +189 lines, -1 line 0 comments Download
M test/cctest/test-assembler-mips64.cc View 1 2 3 4 2 chunks +184 lines, -1 line 0 comments Download

Messages

Total messages: 41 (25 generated)
dusan.simicic
PTAL
3 years, 8 months ago (2017-04-06 15:31:55 UTC) #2
dusan.simicic
+ Ilija.Pavlovic PTAL
3 years, 8 months ago (2017-04-19 13:52:24 UTC) #4
Ilija.Pavlovic1
https://codereview.chromium.org/2799923002/diff/1/src/mips/simulator-mips.cc File src/mips/simulator-mips.cc (right): https://codereview.chromium.org/2799923002/diff/1/src/mips/simulator-mips.cc#newcode4551 src/mips/simulator-mips.cc:4551: uint32_t opcode = instr_.InstructionBits() & kMsa2RMask; Maybe "operation" is ...
3 years, 8 months ago (2017-04-20 13:13:46 UTC) #6
dusan.simicic
https://codereview.chromium.org/2799923002/diff/1/src/mips/simulator-mips.cc File src/mips/simulator-mips.cc (right): https://codereview.chromium.org/2799923002/diff/1/src/mips/simulator-mips.cc#newcode4551 src/mips/simulator-mips.cc:4551: uint32_t opcode = instr_.InstructionBits() & kMsa2RMask; On 2017/04/20 13:13:46, ...
3 years, 8 months ago (2017-04-20 15:57:42 UTC) #8
ivica.bogosavljevic
https://codereview.chromium.org/2799923002/diff/20001/src/mips64/simulator-mips64.h File src/mips64/simulator-mips64.h (right): https://codereview.chromium.org/2799923002/diff/20001/src/mips64/simulator-mips64.h#newcode267 src/mips64/simulator-mips64.h:267: void get_msa_register(int wreg, T* value); Can we have T ...
3 years, 7 months ago (2017-05-15 15:05:36 UTC) #9
dusan.simicic
https://codereview.chromium.org/2799923002/diff/20001/src/mips64/simulator-mips64.h File src/mips64/simulator-mips64.h (right): https://codereview.chromium.org/2799923002/diff/20001/src/mips64/simulator-mips64.h#newcode267 src/mips64/simulator-mips64.h:267: void get_msa_register(int wreg, T* value); On 2017/05/15 15:05:36, ivica.bogosavljevic ...
3 years, 7 months ago (2017-05-16 13:12:41 UTC) #10
ivica.bogosavljevic
On 2017/05/16 13:12:41, dusan.simicic wrote: > https://codereview.chromium.org/2799923002/diff/20001/src/mips64/simulator-mips64.h > File src/mips64/simulator-mips64.h (right): > > https://codereview.chromium.org/2799923002/diff/20001/src/mips64/simulator-mips64.h#newcode267 > ...
3 years, 7 months ago (2017-05-19 12:44:01 UTC) #11
Ilija.Pavlovic1
lgtm with nit: to make additional test where writing is done in FPU(i) and after ...
3 years, 7 months ago (2017-05-22 08:24:12 UTC) #13
dusan.simicic
PS4: Added additional tests for FPU-MSA registers overlapping
3 years, 7 months ago (2017-05-23 10:12:50 UTC) #15
Ilija.Pavlovic1
lgtm
3 years, 7 months ago (2017-05-24 05:47:57 UTC) #21
miran.karic
LGTM with nits: Typo in description, sceleton -> skeleton. https://codereview.chromium.org/2799923002/diff/60001/src/mips/simulator-mips.h File src/mips/simulator-mips.h (right): https://codereview.chromium.org/2799923002/diff/60001/src/mips/simulator-mips.h#newcode185 src/mips/simulator-mips.h:185: ...
3 years, 7 months ago (2017-05-24 13:48:06 UTC) #23
dusan.simicic
https://codereview.chromium.org/2799923002/diff/60001/src/mips/simulator-mips.h File src/mips/simulator-mips.h (right): https://codereview.chromium.org/2799923002/diff/60001/src/mips/simulator-mips.h#newcode185 src/mips/simulator-mips.h:185: enum MSARegister { On 2017/05/24 13:48:06, miran.karic wrote: > ...
3 years, 7 months ago (2017-05-24 14:00:23 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799923002/60001
3 years, 7 months ago (2017-05-25 08:55:37 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/38003) v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
3 years, 7 months ago (2017-05-25 08:57:07 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799923002/80001
3 years, 7 months ago (2017-05-25 09:41:48 UTC) #38
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 14:51:19 UTC) #41
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/1f06818739692786c30f67fbfeda6352134...

Powered by Google App Engine
This is Rietveld 408576698