Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(150)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/browser/engagement/OWNERS
Issue
2783433003
:
Move site_engagement.mojom to chrome/browser/engagement. (Closed)
Patch Set: Fix missed references to the old path
Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/BUILD.gn
chrome/browser/browser_resources.grd
chrome/browser/engagement/BUILD.gn
chrome/browser/engagement/OWNERS
chrome/browser/engagement/site_engagement.mojom
chrome/browser/resources/engagement/site_engagement.js
chrome/browser/ui/BUILD.gn
chrome/browser/ui/webui/engagement/BUILD.gn
chrome/browser/ui/webui/engagement/OWNERS
chrome/browser/ui/webui/engagement/site_engagement.mojom
chrome/browser/ui/webui/engagement/site_engagement_ui.h
chrome/browser/ui/webui/engagement/site_engagement_ui.cc
View unified diff
|
Download patch
« chrome/browser/engagement/BUILD.gn
('K') |
« chrome/browser/engagement/BUILD.gn
('k') |
chrome/browser/engagement/site_engagement.mojom »
('j') |
chrome/browser/engagement/site_engagement.mojom »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1
per-file *.mojom=set noparent
2
per-file *.mojom=file://ipc/SECURITY_OWNERS
3
1 benwells@chromium.org
4 benwells@chromium.org
2 calamity@chromium.org
5 calamity@chromium.org
3 dominickn@chromium.org
6 dominickn@chromium.org
4 raymes@chromium.org
7 raymes@chromium.org
5
8
6 # COMPONENT: Internals>Permissions>SiteEngagement
9 # COMPONENT: Internals>Permissions>SiteEngagement
OLD
NEW
« chrome/browser/engagement/BUILD.gn
('K') |
« chrome/browser/engagement/BUILD.gn
('k') |
chrome/browser/engagement/site_engagement.mojom »
('j') |
chrome/browser/engagement/site_engagement.mojom »
('J')
Issue 2783433003: Move site_engagement.mojom to chrome/browser/engagement. (Closed)
Created 3 years, 8 months ago by Wez
Modified 3 years, 8 months ago
Reviewers: dominickn, sky, dcheng
Base URL:
Comments: 4
This is Rietveld
408576698