Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: components/nacl/loader/nacl_ipc_adapter.h

Issue 2781443004: Convert NaClIPCAdapter::RewrittenMessage ownership management from shared to unique (Closed)
Patch Set: s/scoped_refptr/std::unique_ptr/ Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/nacl/loader/nacl_ipc_adapter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/loader/nacl_ipc_adapter.h
diff --git a/components/nacl/loader/nacl_ipc_adapter.h b/components/nacl/loader/nacl_ipc_adapter.h
index 1f4e6e0833bc24ff311e30793c7a889661c9f07b..f48ff32ac5f7055212a89afe66b3cbe19854fe4a 100644
--- a/components/nacl/loader/nacl_ipc_adapter.h
+++ b/components/nacl/loader/nacl_ipc_adapter.h
@@ -153,7 +153,7 @@ class NaClIPCAdapter : public base::RefCountedThreadSafe<NaClIPCAdapter>,
// Messages that we have read off of the Chrome IPC channel that are waiting
// to be received by the plugin.
- std::queue< scoped_refptr<RewrittenMessage> > to_be_received_;
+ std::queue<std::unique_ptr<RewrittenMessage>> to_be_received_;
ppapi::proxy::NaClMessageScanner nacl_msg_scanner_;
@@ -210,7 +210,7 @@ class NaClIPCAdapter : public base::RefCountedThreadSafe<NaClIPCAdapter>,
// Saves the message to forward to NaCl. This method assumes that the caller
// holds the lock for locked_data_.
void SaveMessage(const IPC::Message& message,
- RewrittenMessage* rewritten_message);
+ std::unique_ptr<RewrittenMessage> rewritten_message);
base::Lock lock_;
base::ConditionVariable cond_var_;
« no previous file with comments | « no previous file | components/nacl/loader/nacl_ipc_adapter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698