Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2778713002: Clean up DEPS files under Source/modules (Closed)

Created:
3 years, 9 months ago by tyoshino (SeeGerritForStatus)
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, tzik, mlamouri+watch-screen-orientation_chromium.org, johnme+watch_chromium.org, eric.carlson_apple.com, scheib+watch_chromium.org, ortuno+watch_chromium.org, dmazzoni+watch_chromium.org, Srirama, jsbell+serviceworker_chromium.org, awdf+watch_chromium.org, aboxhall, mvanouwerkerk+watch_chromium.org, aboxhall+watch_chromium.org, chasej+watch_chromium.org, hongchan, nhiroki, je_julie, jkarlin+watch_chromium.org, wanming.lin, blink-reviews, gyuyoung2, falken+watch_chromium.org, harkness+watch_chromium.org, cmumford, Peter Beverloo, timvolodine, Raymond Toy, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, dmazzoni, yuzo+watch_chromium.org, jsbell+idb_chromium.org, michaeln, shimazu+serviceworker_chromium.org, emircan+watch+mediarecorder_chromium.org, toyoshim+midi_chromium.org, shalamov, mlamouri+watch-blink_chromium.org, serviceworker-reviews, nektar+watch_chromium.org, mcasas+geolocation_chromium.org, iclelland+watch_chromium.org, nektarios, dougt+watch_chromium.org, kinuko+serviceworker, dtseng+watch_chromium.org, horo+watch_chromium.org, mcasas+mediarecorder_chromium.org, kinuko+fileapi, jshin+watch_chromium.org, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up DEPS files under Source/modules - Remove rules in modules/DEPS or root DEPS as they get inherited. - Omit third_party/WebKit/Source in modules/csspaint/DEPS - Remove unnecessary explicit dependencies to subdirectories where whose parent is already included - Remove a deps in modules/shapedetection/DEPS to non-existent directory heap R=haraken@chromium.org BUG=none Review-Url: https://codereview.chromium.org/2778713002 Cr-Commit-Position: refs/heads/master@{#460050} Committed: https://chromium.googlesource.com/chromium/src/+/184961b20d7bb0167de6eb29c5bc74180e3cc562

Patch Set 1 #

Patch Set 2 : Fixed csspaint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -193 lines) Patch
M third_party/WebKit/Source/modules/accessibility/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/background_sync/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/battery/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/DEPS View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/crypto/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/DEPS View 1 1 chunk +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/device_light/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DEPS View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/donottrack/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/encoding/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/media_capabilities/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediacapturefromelement/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasession/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasource/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/navigatorcontentutils/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/netinfo/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/DEPS View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/DEPS View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/vibration/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DEPS View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/DEPS View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
tyoshino (SeeGerritForStatus)
3 years, 9 months ago (2017-03-27 11:01:59 UTC) #4
tyoshino (SeeGerritForStatus)
On 2017/03/27 11:01:59, tyoshino wrote: Oops, I need to fix https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/417005
3 years, 9 months ago (2017-03-27 11:02:45 UTC) #5
tyoshino (SeeGerritForStatus)
On 2017/03/27 11:02:45, tyoshino wrote: > On 2017/03/27 11:01:59, tyoshino wrote: > > Oops, I ...
3 years, 9 months ago (2017-03-27 11:09:00 UTC) #6
tyoshino (SeeGerritForStatus)
On 2017/03/27 11:09:00, tyoshino wrote: > On 2017/03/27 11:02:45, tyoshino wrote: > > On 2017/03/27 ...
3 years, 9 months ago (2017-03-27 11:09:57 UTC) #7
tyoshino (SeeGerritForStatus)
On 2017/03/27 11:09:57, tyoshino wrote: > On 2017/03/27 11:09:00, tyoshino wrote: > > On 2017/03/27 ...
3 years, 9 months ago (2017-03-28 02:56:08 UTC) #10
haraken
LGTM
3 years, 9 months ago (2017-03-28 06:39:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778713002/20001
3 years, 9 months ago (2017-03-28 07:36:17 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/184961b20d7bb0167de6eb29c5bc74180e3cc562
3 years, 9 months ago (2017-03-28 09:27:07 UTC) #17
tyoshino (SeeGerritForStatus)
3 years, 9 months ago (2017-03-28 10:37:14 UTC) #18
Message was sent while issue was closed.
Filed http://crbug.com/705921 to suggest that the presubmit script warns when
bad entries are added to DEPS.

Powered by Google App Engine
This is Rietveld 408576698