Issue 2774423002: [NTP Client] Add CondensedNTP to test fieldtrial config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2774423002: [NTP Client] Add CondensedNTP to test fieldtrial config (Closed)

Created:
3 years, 9 months ago by dgn

Modified:
3 years, 9 months ago

Reviewers:
Marc Treib, rkaplow

CC:
chromium-reviews

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[NTP Client] Add CondensedNTP to test fieldtrial config BUG=703162

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
	M	testing/variations/fieldtrial_testing_config.json	View		1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

dgn

PTAL. Finch presubmit asks for that before allowing to land beta configs. (context: cl/151339379)

3 years, 9 months ago (2017-03-27 17:58:49 UTC) #2

dgn

3 years, 9 months ago (2017-03-28 10:10:58 UTC) #4

Pulling back this review. It's not required for canary/dev experiments (where
we're at for now) and we still want the default state to be tested anyway, as
the experiment is not going to target 100% of population when going over to
beta.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages