Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: ios/chrome/browser/about_flags.mm

Issue 2774203002: Migrate about:flags messages to const char* (Closed)
Patch Set: fix iOS compilation Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/OWNERS ('k') | ios/chrome/browser/ios_chrome_flag_descriptions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/about_flags.mm
diff --git a/ios/chrome/browser/about_flags.mm b/ios/chrome/browser/about_flags.mm
index d29dc0f40d043ea2c96326d9a355c1fd243f81cc..c456d777769bd7f7988cab9a438c6176a277ffe8 100644
--- a/ios/chrome/browser/about_flags.mm
+++ b/ios/chrome/browser/about_flags.mm
@@ -28,6 +28,7 @@
#include "components/ntp_tiles/switches.h"
#include "components/strings/grit/components_strings.h"
#include "ios/chrome/browser/chrome_switches.h"
+#include "ios/chrome/browser/ios_chrome_flag_descriptions.h"
#include "ios/chrome/grit/ios_strings.h"
#include "ios/public/provider/chrome/browser/chrome_browser_provider.h"
#include "ios/web/public/user_agent.h"
@@ -54,16 +55,16 @@ namespace {
//
// When adding a new choice, add it to the end of the list.
const flags_ui::FeatureEntry kFeatureEntries[] = {
- {"contextual-search", IDS_IOS_FLAGS_CONTEXTUAL_SEARCH,
- IDS_IOS_FLAGS_CONTEXTUAL_SEARCH_DESCRIPTION, flags_ui::kOsIos,
+ {"contextual-search", flag_descriptions::kContextualSearch,
+ flag_descriptions::kContextualSearchDescription, flags_ui::kOsIos,
ENABLE_DISABLE_VALUE_TYPE(switches::kEnableContextualSearch,
switches::kDisableContextualSearch)},
- {"ios-physical-web", IDS_IOS_FLAGS_PHYSICAL_WEB,
- IDS_IOS_FLAGS_PHYSICAL_WEB_DESCRIPTION, flags_ui::kOsIos,
+ {"ios-physical-web", flag_descriptions::kPhysicalWeb,
+ flag_descriptions::kPhysicalWebDescription, flags_ui::kOsIos,
ENABLE_DISABLE_VALUE_TYPE(switches::kEnableIOSPhysicalWeb,
switches::kDisableIOSPhysicalWeb)},
- {"browser-task-scheduler", IDS_IOS_FLAGS_BROWSER_TASK_SCHEDULER_NAME,
- IDS_IOS_FLAGS_BROWSER_TASK_SCHEDULER_DESCRIPTION, flags_ui::kOsIos,
+ {"browser-task-scheduler", flag_descriptions::kBrowserTaskScheduler,
+ flag_descriptions::kBrowserTaskSchedulerDescription, flags_ui::kOsIos,
ENABLE_DISABLE_VALUE_TYPE(switches::kEnableBrowserTaskScheduler,
switches::kDisableBrowserTaskScheduler)},
};
« no previous file with comments | « ios/chrome/browser/OWNERS ('k') | ios/chrome/browser/ios_chrome_flag_descriptions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698