Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: components/flags_ui/feature_entry.h

Issue 2774203002: Migrate about:flags messages to const char* (Closed)
Patch Set: fix iOS compilation Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/flag_descriptions.cc ('k') | components/flags_ui/feature_entry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/flags_ui/feature_entry.h
diff --git a/components/flags_ui/feature_entry.h b/components/flags_ui/feature_entry.h
index b32d500372dc1f7049893478fc4e0e64b160c275..64283844bc5c0f27acd9ae45817c49733c026e14 100644
--- a/components/flags_ui/feature_entry.h
+++ b/components/flags_ui/feature_entry.h
@@ -15,6 +15,12 @@ struct Feature;
namespace flags_ui {
+// Generic experiment choice option names.
+extern const char kGenericExperimentChoiceDefault[];
+extern const char kGenericExperimentChoiceEnabled[];
+extern const char kGenericExperimentChoiceDisabled[];
+extern const char kGenericExperimentChoiceAutomatic[];
+
// FeatureEntry is used to describe an experimental feature.
//
// Note that features should eventually be either turned on by default with no
@@ -82,8 +88,8 @@ struct FeatureEntry {
// Used for MULTI_VALUE types to describe one of the possible values the user
// can select.
struct Choice {
- // ID of the message containing the choice name.
- int description_id;
+ // The message containing the choice name.
+ const char* description;
// Command line switch and value to enabled for this choice.
const char* command_line_switch;
@@ -120,11 +126,11 @@ struct FeatureEntry {
// name of existing flags.
const char* internal_name;
- // String id of the message containing the feature's name.
- int visible_name_id;
+ // The feature's name.
+ const char* visible_name;
- // String id of the message containing the feature's description.
- int visible_description_id;
+ // The feature's description.
+ const char* visible_description;
// The platforms the feature is available on.
// Needs to be more than a compile-time #ifdef because of profile sync.
« no previous file with comments | « chrome/browser/flag_descriptions.cc ('k') | components/flags_ui/feature_entry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698