Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Unified Diff: src/asmjs/asm-scanner.cc

Issue 2771183002: [wasm][asm.js] Fix and enable several asm.js tests with the new parser. (Closed)
Patch Set: fix one more item Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/asmjs/asm-parser.cc ('k') | src/wasm/wasm-module.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/asmjs/asm-scanner.cc
diff --git a/src/asmjs/asm-scanner.cc b/src/asmjs/asm-scanner.cc
index 949b44a65f7bb773cdd190ed5240855aaa139ffe..571930f4815537b7c4e054f6181c90d7184280fd 100644
--- a/src/asmjs/asm-scanner.cc
+++ b/src/asmjs/asm-scanner.cc
@@ -145,12 +145,14 @@ void AsmJsScanner::Next() {
}
void AsmJsScanner::Rewind() {
+ // TODO(bradnelson): Currently rewinding needs to leave in place the
+ // preceding newline state (in case a |0 ends a line).
+ // This is weird and stateful, fix me.
DCHECK(!rewind_);
next_token_ = token_;
token_ = preceding_token_;
preceding_token_ = kUninitialized;
rewind_ = true;
- preceded_by_newline_ = false;
identifier_string_.clear();
}
« no previous file with comments | « src/asmjs/asm-parser.cc ('k') | src/wasm/wasm-module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698