Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 2765923003: Extend notifications.mojom for expandable notifications. (Closed)

Created:
3 years, 9 months ago by yhanada
Modified:
3 years, 8 months ago
Reviewers:
hidehiko, yoshiki, dcheng
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, viettrungluu+watch_chromium.org, Peter Beverloo, hidehiko+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, lhchavez+watch_chromium.org, awdf+watch_chromium.org, victorhsieh+watch_chromium.org, darin (slow to review), mlamouri+watch-notifications_chromium.org, qsr+mojo_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Extend notifications.mojom for expandable notifications. - Add |TOGGLE_EXPANSION| value to ArcNotificationEvent enum. - Add |expand_state| value to ArcNotificationData. BUG=703989 Review-Url: https://codereview.chromium.org/2765923003 Cr-Commit-Position: refs/heads/master@{#460062} Committed: https://chromium.googlesource.com/chromium/src/+/c787104b181d6ca1356c1f0b82257ed5a62ad633

Patch Set 1 #

Patch Set 2 #

Total comments: 1

Patch Set 3 : delete message_center::NotificationExpandState #

Total comments: 1

Patch Set 4 : mark as Extensible #

Patch Set 5 : add Minversion to the enum #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M components/arc/common/notifications.mojom View 1 2 3 4 4 chunks +13 lines, -1 line 0 comments Download
M ui/arc/notification/arc_custom_notification_item.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_item.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 38 (27 generated)
yhanada
Hi, PTAL.
3 years, 9 months ago (2017-03-24 08:16:20 UTC) #5
yoshiki
https://codereview.chromium.org/2765923003/diff/20001/ui/arc/notification/arc_custom_notification_item.cc File ui/arc/notification/arc_custom_notification_item.cc (right): https://codereview.chromium.org/2765923003/diff/20001/ui/arc/notification/arc_custom_notification_item.cc#newcode53 ui/arc/notification/arc_custom_notification_item.cc:53: message_center::NotificationExpandState ToNotificationExpandState( I think it's enough to use the ...
3 years, 9 months ago (2017-03-24 10:47:28 UTC) #12
yhanada
On 2017/03/24 10:47:28, yoshiki wrote: > https://codereview.chromium.org/2765923003/diff/20001/ui/arc/notification/arc_custom_notification_item.cc > File ui/arc/notification/arc_custom_notification_item.cc (right): > > https://codereview.chromium.org/2765923003/diff/20001/ui/arc/notification/arc_custom_notification_item.cc#newcode53 > ...
3 years, 9 months ago (2017-03-24 10:51:05 UTC) #13
yoshiki
On 2017/03/24 10:51:05, yhanada wrote: > On 2017/03/24 10:47:28, yoshiki wrote: > > > https://codereview.chromium.org/2765923003/diff/20001/ui/arc/notification/arc_custom_notification_item.cc ...
3 years, 9 months ago (2017-03-24 13:42:08 UTC) #14
yhanada
On 2017/03/24 13:42:08, yoshiki wrote: > On 2017/03/24 10:51:05, yhanada wrote: > > On 2017/03/24 ...
3 years, 9 months ago (2017-03-27 05:42:39 UTC) #17
yoshiki
Thanks! It gets much simpler! LGTM. But please get approvals from an ARC owner (hidehiko ...
3 years, 9 months ago (2017-03-27 06:00:43 UTC) #18
yhanada
hidehide@: Could you review changes in components/arc as an OWNER? dcheng@: Could you review changes ...
3 years, 9 months ago (2017-03-27 06:04:19 UTC) #20
dcheng
LGTM https://codereview.chromium.org/2765923003/diff/40001/components/arc/common/notifications.mojom File components/arc/common/notifications.mojom (right): https://codereview.chromium.org/2765923003/diff/40001/components/arc/common/notifications.mojom#newcode41 components/arc/common/notifications.mojom:41: enum ArcNotificationExpandState { Is the general rule for ...
3 years, 9 months ago (2017-03-28 02:29:25 UTC) #23
yhanada
On 2017/03/28 02:29:25, dcheng wrote: > LGTM > > https://codereview.chromium.org/2765923003/diff/40001/components/arc/common/notifications.mojom > File components/arc/common/notifications.mojom (right): > ...
3 years, 9 months ago (2017-03-28 04:27:24 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765923003/80001
3 years, 8 months ago (2017-03-28 11:50:35 UTC) #35
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 11:55:42 UTC) #38
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/c787104b181d6ca1356c1f0b8225...

Powered by Google App Engine
This is Rietveld 408576698