third_party/WebKit/Source/web/WebNode.cpp - Issue 2764313002: Move plugins to be stored in HTMLPlugInElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebNode.cpp

Issue 2764313002: Move plugins to be stored in HTMLPlugInElement. (Closed)

Patch Set: Update comments about duplicating code Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebNode.cpp

diff --git a/third_party/WebKit/Source/web/WebNode.cpp b/third_party/WebKit/Source/web/WebNode.cpp

index c9f1b44feed0689cca15575e4489d784d5f01d9f..6c1b8e2ab62c123f1dc3b0d11ab9831249f3e906 100644

--- a/third_party/WebKit/Source/web/WebNode.cpp

+++ b/third_party/WebKit/Source/web/WebNode.cpp

@@ -186,9 +186,9 @@ WebPluginContainer* WebNode::pluginContainerFromNode(const Node* node) {

LayoutObject* object = node->layoutObject();

if (object && object->isLayoutPart()) {

- FrameViewBase* frameViewBase = toLayoutPart(object)->frameViewBase();

- if (frameViewBase && frameViewBase->isPluginContainer())

- return toWebPluginContainerImpl(frameViewBase);

+ PluginView* plugin = toLayoutPart(object)->plugin();

+ if (plugin && plugin->isPluginContainer())

+ return toWebPluginContainerImpl(plugin);

}

return nullptr;