Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2764313002: Move plugins to be stored in HTMLPlugInElement. (Closed)
Patch Set: Update comments about duplicating code Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
index 4481a0d4ea98aae39d46cd10d88291f8288cc3ba..ede2d3316759f9cf1a4890c1a077eee9846751f4 100644
--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp
+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
@@ -646,10 +646,9 @@ void ChromeClientImpl::showMouseOverURL(const HitTestResult& result) {
isHTMLEmbedElement(*result.innerNode()))) {
LayoutObject* object = result.innerNode()->layoutObject();
if (object && object->isLayoutPart()) {
- FrameViewBase* frameViewBase = toLayoutPart(object)->frameViewBase();
- if (frameViewBase && frameViewBase->isPluginContainer()) {
- WebPluginContainerImpl* plugin =
- toWebPluginContainerImpl(frameViewBase);
+ PluginView* pluginView = toLayoutPart(object)->plugin();
+ if (pluginView && pluginView->isPluginContainer()) {
+ WebPluginContainerImpl* plugin = toWebPluginContainerImpl(pluginView);
url = plugin->plugin()->linkAtPosition(
result.roundedPointInInnerNodeFrame());
}

Powered by Google App Engine
This is Rietveld 408576698