Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2477)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutPart.h

Issue 2764313002: Move plugins to be stored in HTMLPlugInElement. (Closed)
Patch Set: Update comments about duplicating code Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutPart.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutPart.h b/third_party/WebKit/Source/core/layout/LayoutPart.h
index 9a48047a851ef5106d944bbd28ebec283a809463..26047b1fe0817ac9751a719d7d5146e056aa4a68 100644
--- a/third_party/WebKit/Source/core/layout/LayoutPart.h
+++ b/third_party/WebKit/Source/core/layout/LayoutPart.h
@@ -25,6 +25,7 @@
#include "core/CoreExport.h"
#include "core/layout/LayoutReplaced.h"
+#include "core/plugins/PluginView.h"
#include "platform/FrameViewBase.h"
namespace blink {
@@ -49,6 +50,12 @@ class CORE_EXPORT LayoutPart : public LayoutReplaced {
void deref();
FrameViewBase* frameViewBase() const;
+ PluginView* plugin() const;
+ // TODO(joelhockey): This method will be removed once FrameViewBase
+ // class is removed. New abstract base classes will be defined
+ // for when polymorphism is required for plugins and frames and
+ // other methods provided.
+ FrameViewBase* pluginOrFrame() const;
LayoutRect replacedContentRect() const final;
@@ -73,7 +80,7 @@ class CORE_EXPORT LayoutPart : public LayoutReplaced {
const PaintInvalidationState&) override;
private:
- void updateGeometryInternal();
+ void updateGeometryInternal(FrameViewBase&);
CompositingReasons additionalCompositingReasons() const override;
void willBeDestroyed() final;

Powered by Google App Engine
This is Rietveld 408576698