Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2764313002: Move plugins to be stored in HTMLPlugInElement. (Closed)
Patch Set: Update comments about duplicating code Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.h
diff --git a/third_party/WebKit/Source/core/frame/FrameView.h b/third_party/WebKit/Source/core/frame/FrameView.h
index 487f1d86ad9e9ff2c3f6089b2ec80099c6854a62..82abd868b2ccaebaa3861518dd4589efc38f60ce 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.h
+++ b/third_party/WebKit/Source/core/frame/FrameView.h
@@ -39,6 +39,7 @@
#include "core/paint/PaintInvalidationCapableScrollableArea.h"
#include "core/paint/PaintPhase.h"
#include "core/paint/ScrollbarManager.h"
+#include "core/plugins/PluginView.h"
#include "platform/FrameViewBase.h"
#include "platform/RuntimeEnabledFeatures.h"
#include "platform/animation/CompositorAnimationHost.h"
@@ -454,12 +455,16 @@ class CORE_EXPORT FrameView final
HostWindow* getHostWindow() const;
typedef HeapHashSet<Member<FrameViewBase>> ChildrenSet;
+ typedef HeapHashSet<Member<PluginView>> PluginsSet;
// Functions for child manipulation and inspection.
void setParent(FrameViewBase*) override;
void removeChild(FrameViewBase*);
void addChild(FrameViewBase*);
const ChildrenSet* children() const { return &m_children; }
+ void removePlugin(PluginView*);
+ void addPlugin(PluginView*);
+ const PluginsSet* plugins() const { return &m_plugins; }
// If the scroll view does not use a native widget, then it will have
// cross-platform Scrollbars. These functions can be used to obtain those
@@ -1128,6 +1133,7 @@ class CORE_EXPORT FrameView final
bool m_verticalScrollbarLock;
ChildrenSet m_children;
+ PluginsSet m_plugins;
ScrollOffset m_pendingScrollDelta;
ScrollOffset m_scrollOffset;

Powered by Google App Engine
This is Rietveld 408576698