Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: PRESUBMIT.py

Issue 2761163003: Use local pages for webrtc telemetry tests. (Closed)
Patch Set: Exclude all of webrtc_cases in PRESUBMIT.py and add a comment explaining it is because these are te… Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/data/webrtc_audio_cases.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
11 11
12 _EXCLUDED_PATHS = ( 12 _EXCLUDED_PATHS = (
13 r"^breakpad[\\\/].*", 13 r"^breakpad[\\\/].*",
14 r"^native_client_sdk[\\\/]src[\\\/]build_tools[\\\/]make_rules.py", 14 r"^native_client_sdk[\\\/]src[\\\/]build_tools[\\\/]make_rules.py",
15 r"^native_client_sdk[\\\/]src[\\\/]build_tools[\\\/]make_simple.py", 15 r"^native_client_sdk[\\\/]src[\\\/]build_tools[\\\/]make_simple.py",
16 r"^native_client_sdk[\\\/]src[\\\/]tools[\\\/].*.mk", 16 r"^native_client_sdk[\\\/]src[\\\/]tools[\\\/].*.mk",
17 r"^net[\\\/]tools[\\\/]spdyshark[\\\/].*", 17 r"^net[\\\/]tools[\\\/]spdyshark[\\\/].*",
18 r"^skia[\\\/].*", 18 r"^skia[\\\/].*",
19 r"^third_party[\\\/]WebKit[\\\/].*", 19 r"^third_party[\\\/]WebKit[\\\/].*",
20 r"^v8[\\\/].*", 20 r"^v8[\\\/].*",
21 r".*MakeFile$", 21 r".*MakeFile$",
22 r".+_autogen\.h$", 22 r".+_autogen\.h$",
23 r".+[\\\/]pnacl_shim\.c$", 23 r".+[\\\/]pnacl_shim\.c$",
24 r"^gpu[\\\/]config[\\\/].*_list_json\.cc$", 24 r"^gpu[\\\/]config[\\\/].*_list_json\.cc$",
25 r"^chrome[\\\/]browser[\\\/]resources[\\\/]pdf[\\\/]index.js", 25 r"^chrome[\\\/]browser[\\\/]resources[\\\/]pdf[\\\/]index.js",
26 r".*vulcanized.html$", 26 r".*vulcanized.html$",
27 r".*crisper.js$", 27 r".*crisper.js$",
28 r"tools[\\\/]md_browser[\\\/].*\.css$", 28 r"tools[\\\/]md_browser[\\\/].*\.css$",
29 # Test pages for WebRTC telemetry tests.
30 r"tools[\\\/]perf[\\\/]page_sets[\\\/]webrtc_cases.*",
29 ) 31 )
30 32
31 33
32 # Fragment of a regular expression that matches C++ and Objective-C++ 34 # Fragment of a regular expression that matches C++ and Objective-C++
33 # implementation files. 35 # implementation files.
34 _IMPLEMENTATION_EXTENSIONS = r'\.(cc|cpp|cxx|mm)$' 36 _IMPLEMENTATION_EXTENSIONS = r'\.(cc|cpp|cxx|mm)$'
35 37
36 38
37 # Regular expression that matches code only used for test binaries 39 # Regular expression that matches code only used for test binaries
38 # (best effort). 40 # (best effort).
(...skipping 2333 matching lines...) Expand 10 before | Expand all | Expand 10 after
2372 output_api, 2374 output_api,
2373 json_url='http://chromium-status.appspot.com/current?format=json')) 2375 json_url='http://chromium-status.appspot.com/current?format=json'))
2374 2376
2375 results.extend( 2377 results.extend(
2376 input_api.canned_checks.CheckPatchFormatted(input_api, output_api)) 2378 input_api.canned_checks.CheckPatchFormatted(input_api, output_api))
2377 results.extend(input_api.canned_checks.CheckChangeHasBugField( 2379 results.extend(input_api.canned_checks.CheckChangeHasBugField(
2378 input_api, output_api)) 2380 input_api, output_api))
2379 results.extend(input_api.canned_checks.CheckChangeHasDescription( 2381 results.extend(input_api.canned_checks.CheckChangeHasDescription(
2380 input_api, output_api)) 2382 input_api, output_api))
2381 return results 2383 return results
OLDNEW
« no previous file with comments | « no previous file | tools/perf/page_sets/data/webrtc_audio_cases.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698