Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: content/browser/indexed_db/leveldb/leveldb_unittest.cc

Issue 2760163002: [IndexedDB] Pool and evict leveldb iterators, to save memory (Closed)
Patch Set: comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/leveldb/leveldb_unittest.cc
diff --git a/content/browser/indexed_db/leveldb/leveldb_unittest.cc b/content/browser/indexed_db/leveldb/leveldb_unittest.cc
index 379a6ba484b09f2123a3d6dd131b730df4dee93e..3c69af2827a8ef6e5184d58468cf0dc23b839c68 100644
--- a/content/browser/indexed_db/leveldb/leveldb_unittest.cc
+++ b/content/browser/indexed_db/leveldb/leveldb_unittest.cc
@@ -21,6 +21,7 @@
namespace content {
namespace {
+static const size_t kDefaultMaxOpenIteratorsPerDatabase = 50;
class SimpleComparator : public LevelDBComparator {
public:
@@ -45,7 +46,8 @@ TEST(LevelDBDatabaseTest, CorruptionTest) {
SimpleComparator comparator;
std::unique_ptr<LevelDBDatabase> leveldb;
- LevelDBDatabase::Open(temp_directory.GetPath(), &comparator, &leveldb);
+ LevelDBDatabase::Open(temp_directory.GetPath(), &comparator,
+ kDefaultMaxOpenIteratorsPerDatabase, &leveldb);
EXPECT_TRUE(leveldb);
put_value = value;
leveldb::Status status = leveldb->Put(key, &put_value);
@@ -53,7 +55,8 @@ TEST(LevelDBDatabaseTest, CorruptionTest) {
leveldb.reset();
EXPECT_FALSE(leveldb);
- LevelDBDatabase::Open(temp_directory.GetPath(), &comparator, &leveldb);
+ LevelDBDatabase::Open(temp_directory.GetPath(), &comparator,
+ kDefaultMaxOpenIteratorsPerDatabase, &leveldb);
EXPECT_TRUE(leveldb);
bool found = false;
status = leveldb->Get(key, &got_value, &found);
@@ -68,8 +71,8 @@ TEST(LevelDBDatabaseTest, CorruptionTest) {
file.SetLength(0);
file.Close();
- status =
- LevelDBDatabase::Open(temp_directory.GetPath(), &comparator, &leveldb);
+ status = LevelDBDatabase::Open(temp_directory.GetPath(), &comparator,
+ kDefaultMaxOpenIteratorsPerDatabase, &leveldb);
EXPECT_FALSE(leveldb);
EXPECT_FALSE(status.ok());
EXPECT_TRUE(status.IsCorruption());
@@ -77,8 +80,8 @@ TEST(LevelDBDatabaseTest, CorruptionTest) {
status = LevelDBDatabase::Destroy(temp_directory.GetPath());
EXPECT_TRUE(status.ok());
- status =
- LevelDBDatabase::Open(temp_directory.GetPath(), &comparator, &leveldb);
+ status = LevelDBDatabase::Open(temp_directory.GetPath(), &comparator,
+ kDefaultMaxOpenIteratorsPerDatabase, &leveldb);
EXPECT_TRUE(status.ok());
EXPECT_TRUE(leveldb);
status = leveldb->Get(key, &got_value, &found);

Powered by Google App Engine
This is Rietveld 408576698