Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: content/browser/indexed_db/leveldb/leveldb_iterator.h

Issue 2760163002: [IndexedDB] Pool and evict leveldb iterators, to save memory (Closed)
Patch Set: comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/leveldb/leveldb_iterator.h
diff --git a/content/browser/indexed_db/leveldb/leveldb_iterator.h b/content/browser/indexed_db/leveldb/leveldb_iterator.h
index d5efa4bf51951f6218d0cbcb804e282c6397b4d2..fd2b0defc4818273fe807f2bca45915539414d4c 100644
--- a/content/browser/indexed_db/leveldb/leveldb_iterator.h
+++ b/content/browser/indexed_db/leveldb/leveldb_iterator.h
@@ -21,6 +21,13 @@ class CONTENT_EXPORT LevelDBIterator {
virtual leveldb::Status Prev() = 0;
virtual base::StringPiece Key() const = 0;
virtual base::StringPiece Value() const = 0;
+
+ // Detaches the internal iterator which saves memory at the performance
+ // expense of reloading and seeking later if the iterator is needed again for
+ // |Seek*|, |Next|, |Prev|, or |Value|.
+ // Cannot be called more than once before the iterator is reloaded.
+ virtual void Detach() {};
+ virtual bool IsDetached() const;
};
} // namespace content
« no previous file with comments | « content/browser/indexed_db/leveldb/leveldb_database.cc ('k') | content/browser/indexed_db/leveldb/leveldb_iterator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698