OfflineContentProvider changes to start service

components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineItem.java

Index: components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineItem.java
diff --git a/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineItem.java b/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineItem.java
index c4a9feef9e4b79c9f532082042bec06731457917..dcd4e2ea2679a16b6cd3a5452e53c6a4ce01090b 100644
--- a/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineItem.java
+++ b/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineItem.java
@@ -44,9 +44,14 @@ public class OfflineItem {
     public int percentCompleted;
     public long timeRemainingMs;
 
-    OfflineItem() {
-        id = new ContentId();
+    public OfflineItem() {
+        this.id = new ContentId();

[gone, 2017/03/20 19:03:36]

why add the this. for one of them but not the other two?

[David Trainor- moved to gerrit, 2017/03/25 03:31:13]

Ah sorry I used to allow passing in an id, so I had "this.id = id;"  Didn't
remove the this.

         filter = OfflineItemFilter.FILTER_OTHER;
         state = OfflineItemState.COMPLETE;

[qinmin, 2017/03/22 07:53:58]

should the initial state is COMPLETE?

     }
+
+    @Override
+    public String toString() {
+        return getClass().getSimpleName() + "@" + Integer.toHexString(hashCode()) + " [" + id + "]";

[gone, 2017/03/20 19:03:36]

was this thing automatically added?

[David Trainor- moved to gerrit, 2017/03/25 03:31:13]

No but it makes debugging unit tests easier as mockito likes to print out the
object when things don't work as expected.

+    }
 }