Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2733083004: Emit error events if the loading of an object element failed (Closed)

Created:
3 years, 9 months ago by George Joseph
Modified:
3 years, 6 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Emit error events if the loading of an object element failed Dispatch onerror/error events in the case of a placeholder being instantiated instead of an actual plugin. BUG=445557 Review-Url: https://codereview.chromium.org/2733083004 Cr-Commit-Position: refs/heads/master@{#469081} Committed: https://chromium.googlesource.com/chromium/src/+/f4335e87b019d74e3d803318101922bb40cec682

Patch Set 1 #

Total comments: 4

Patch Set 2 : Emit error events if the loading of an object element failed #

Patch Set 3 : Emit error events if the loading of an object element failed #

Total comments: 2

Patch Set 4 : Emit error events if the loading of an object element failed #

Total comments: 6

Patch Set 5 : Emit error events if the loading of an object element failed #

Total comments: 10

Patch Set 6 : Emit error events if the loading of an object element failed #

Total comments: 7

Patch Set 7 : Emit error events if the loading of an object element failed #

Total comments: 11

Patch Set 8 : Emit error events if the loading of an object element failed #

Total comments: 14

Patch Set 9 : Emit error events if the loading of an object element failed #

Total comments: 4

Patch Set 10 : Emit error events if the loading of an object element failed #

Total comments: 8

Patch Set 11 : Emit error events if the loading of an object element failed #

Total comments: 6

Patch Set 12 : Emit error events if the loading of an object element failed #

Total comments: 8

Patch Set 13 : Emit error events if the loading of an object element failed #

Total comments: 4

Patch Set 14 : Emit error events if the loading of an object element failed #

Total comments: 2

Patch Set 15 : Emit error events if the loading of an object element failed #

Patch Set 16 : Emit error events if the loading of an object element failed #

Patch Set 17 : Emit error events if the loading of an object element failed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -1 line) Patch
M components/plugins/renderer/loadable_plugin_placeholder.h View 1 2 3 4 5 6 8 1 chunk +1 line, -0 lines 0 comments Download
M components/plugins/renderer/loadable_plugin_placeholder.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +4 lines, -0 lines 0 comments Download
M components/plugins/renderer/plugin_placeholder.h View 1 2 3 4 5 6 8 1 chunk +1 line, -0 lines 0 comments Download
M components/plugins/renderer/plugin_placeholder.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +4 lines, -0 lines 0 comments Download
M components/plugins/renderer/webview_plugin.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +4 lines, -0 lines 0 comments Download
M components/plugins/renderer/webview_plugin.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/plugins/PluginView.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/FrameViewBase.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebPlugin.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 103 (36 generated)
George Joseph
3 years, 9 months ago (2017-03-07 23:39:50 UTC) #13
Bernhard Bauer
https://codereview.chromium.org/2733083004/diff/1/components/plugins/renderer/loadable_plugin_placeholder.cc File components/plugins/renderer/loadable_plugin_placeholder.cc (right): https://codereview.chromium.org/2733083004/diff/1/components/plugins/renderer/loadable_plugin_placeholder.cc#newcode75 components/plugins/renderer/loadable_plugin_placeholder.cc:75: plugin()->markAsPlaceholder(); If there is a way that the plugin ...
3 years, 9 months ago (2017-03-08 14:03:14 UTC) #14
George Joseph
Hello Bernhard, Thanks for reviewing the change. Please do review my responses. Thanks, George. https://codereview.chromium.org/2733083004/diff/1/components/plugins/renderer/loadable_plugin_placeholder.cc ...
3 years, 9 months ago (2017-03-08 14:45:58 UTC) #15
George Joseph
Hello Bernhard, Thanks for reviewing the change. Please do review my responses. Thanks, George.
3 years, 9 months ago (2017-03-08 14:46:00 UTC) #16
Bernhard Bauer
https://codereview.chromium.org/2733083004/diff/1/components/plugins/renderer/loadable_plugin_placeholder.cc File components/plugins/renderer/loadable_plugin_placeholder.cc (right): https://codereview.chromium.org/2733083004/diff/1/components/plugins/renderer/loadable_plugin_placeholder.cc#newcode75 components/plugins/renderer/loadable_plugin_placeholder.cc:75: plugin()->markAsPlaceholder(); On 2017/03/08 14:45:57, George Joseph wrote: > On ...
3 years, 9 months ago (2017-03-08 18:01:13 UTC) #18
tommycli
On 2017/03/08 18:01:13, Bernhard Bauer wrote: > https://codereview.chromium.org/2733083004/diff/1/components/plugins/renderer/loadable_plugin_placeholder.cc > File components/plugins/renderer/loadable_plugin_placeholder.cc (right): > > https://codereview.chromium.org/2733083004/diff/1/components/plugins/renderer/loadable_plugin_placeholder.cc#newcode75 ...
3 years, 9 months ago (2017-03-08 18:05:11 UTC) #19
George Joseph
On 2017/03/08 18:05:11, tommycli wrote: > On 2017/03/08 18:01:13, Bernhard Bauer wrote: > > > ...
3 years, 9 months ago (2017-03-08 19:00:15 UTC) #20
George Joseph
https://codereview.chromium.org/2733083004/diff/1/components/plugins/renderer/loadable_plugin_placeholder.cc File components/plugins/renderer/loadable_plugin_placeholder.cc (right): https://codereview.chromium.org/2733083004/diff/1/components/plugins/renderer/loadable_plugin_placeholder.cc#newcode75 components/plugins/renderer/loadable_plugin_placeholder.cc:75: plugin()->markAsPlaceholder(); On 2017/03/08 18:01:13, Bernhard Bauer wrote: > On ...
3 years, 9 months ago (2017-03-08 21:20:42 UTC) #21
groby-ooo-7-16
> Okay, being consistent with Firefox is probably a good idea, but I'd like to ...
3 years, 9 months ago (2017-03-13 16:43:30 UTC) #23
laforge
On 2017/03/13 16:43:30, groby wrote: > > Okay, being consistent with Firefox is probably a ...
3 years, 9 months ago (2017-03-13 16:52:38 UTC) #25
George Joseph
On 2017/03/13 16:52:38, laforge wrote: > On 2017/03/13 16:43:30, groby wrote: > > > Okay, ...
3 years, 9 months ago (2017-03-13 17:59:23 UTC) #26
waffles
On 2017/03/13 17:59:23, George Joseph wrote: > On 2017/03/13 16:52:38, laforge wrote: > > On ...
3 years, 9 months ago (2017-03-13 18:10:05 UTC) #27
George Joseph
On 2017/03/13 18:10:05, waffles wrote: > On 2017/03/13 17:59:23, George Joseph wrote: > > On ...
3 years, 9 months ago (2017-03-14 06:19:08 UTC) #28
George Joseph
On 2017/03/14 06:19:08, George Joseph wrote: > On 2017/03/13 18:10:05, waffles wrote: > > On ...
3 years, 9 months ago (2017-03-14 23:53:14 UTC) #33
tommycli
On 2017/03/14 23:53:14, George Joseph wrote: > On 2017/03/14 06:19:08, George Joseph wrote: > > ...
3 years, 9 months ago (2017-03-15 00:29:06 UTC) #34
tommycli
On 2017/03/15 00:29:06, tommycli wrote: > On 2017/03/14 23:53:14, George Joseph wrote: > > On ...
3 years, 9 months ago (2017-03-15 00:45:47 UTC) #35
tommycli
On 2017/03/15 00:45:47, tommycli wrote: > On 2017/03/15 00:29:06, tommycli wrote: > > On 2017/03/14 ...
3 years, 9 months ago (2017-03-15 00:47:31 UTC) #36
tommycli
https://codereview.chromium.org/2733083004/diff/40001/components/plugins/renderer/loadable_plugin_placeholder.cc File components/plugins/renderer/loadable_plugin_placeholder.cc (right): https://codereview.chromium.org/2733083004/diff/40001/components/plugins/renderer/loadable_plugin_placeholder.cc#newcode75 components/plugins/renderer/loadable_plugin_placeholder.cc:75: plugin()->markAsPlaceholder(); Since some placeholders are temporary, and others are ...
3 years, 9 months ago (2017-03-15 00:58:29 UTC) #37
George Joseph
On 2017/03/15 00:58:29, tommycli wrote: > https://codereview.chromium.org/2733083004/diff/40001/components/plugins/renderer/loadable_plugin_placeholder.cc > File components/plugins/renderer/loadable_plugin_placeholder.cc (right): > > https://codereview.chromium.org/2733083004/diff/40001/components/plugins/renderer/loadable_plugin_placeholder.cc#newcode75 > ...
3 years, 9 months ago (2017-03-15 23:20:21 UTC) #38
waffles
Based on my testing patch set 3 does not interfere with JIT installation of Flash. ...
3 years, 9 months ago (2017-03-17 23:19:49 UTC) #39
waffles
On 2017/03/17 23:19:49, waffles wrote: > Based on my testing patch set 3 does not ...
3 years, 9 months ago (2017-03-17 23:20:42 UTC) #40
George Joseph
On 2017/03/17 23:20:42, waffles wrote: > On 2017/03/17 23:19:49, waffles wrote: > > Based on ...
3 years, 9 months ago (2017-03-22 00:02:58 UTC) #41
George Joseph
https://codereview.chromium.org/2733083004/diff/40001/components/plugins/renderer/loadable_plugin_placeholder.cc File components/plugins/renderer/loadable_plugin_placeholder.cc (right): https://codereview.chromium.org/2733083004/diff/40001/components/plugins/renderer/loadable_plugin_placeholder.cc#newcode75 components/plugins/renderer/loadable_plugin_placeholder.cc:75: plugin()->markAsPlaceholder(); On 2017/03/15 00:58:29, tommycli wrote: > Since some ...
3 years, 9 months ago (2017-03-22 00:04:09 UTC) #42
George Joseph
On 2017/03/22 00:04:09, George Joseph wrote: > https://codereview.chromium.org/2733083004/diff/40001/components/plugins/renderer/loadable_plugin_placeholder.cc > File components/plugins/renderer/loadable_plugin_placeholder.cc (right): > > https://codereview.chromium.org/2733083004/diff/40001/components/plugins/renderer/loadable_plugin_placeholder.cc#newcode75 ...
3 years, 9 months ago (2017-03-24 10:32:34 UTC) #43
Bernhard Bauer
https://codereview.chromium.org/2733083004/diff/60001/third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html File third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html (right): https://codereview.chromium.org/2733083004/diff/60001/third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html#newcode7 third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html:7: var testobject = async_test("crbug.com/445557 : error events aren't dispatched ...
3 years, 8 months ago (2017-03-27 09:20:27 UTC) #44
George Joseph
Hello Bernhard, Thanks for reviewing the changes I made. I have uploaded patchset 5 with ...
3 years, 8 months ago (2017-03-28 10:08:31 UTC) #46
George Joseph
Hello Bernhard, Thanks for reviewing the changes I made. I have uploaded patchset 5 with ...
3 years, 8 months ago (2017-03-28 10:08:35 UTC) #47
Bernhard Bauer
https://codereview.chromium.org/2733083004/diff/80001/components/plugins/renderer/webview_plugin.h File components/plugins/renderer/webview_plugin.h (right): https://codereview.chromium.org/2733083004/diff/80001/components/plugins/renderer/webview_plugin.h#newcode109 components/plugins/renderer/webview_plugin.h:109: void markAsErrorPlaceholder(); These two methods are not overrides of ...
3 years, 8 months ago (2017-03-28 10:55:59 UTC) #48
George Joseph
Hello Bernhard, Thanks for the review comments. I have made changes as proposed and verified ...
3 years, 8 months ago (2017-03-30 08:41:44 UTC) #49
Bernhard Bauer
Mostly nits now. https://codereview.chromium.org/2733083004/diff/100001/components/plugins/renderer/loadable_plugin_placeholder.cc File components/plugins/renderer/loadable_plugin_placeholder.cc (right): https://codereview.chromium.org/2733083004/diff/100001/components/plugins/renderer/loadable_plugin_placeholder.cc#newcode183 components/plugins/renderer/loadable_plugin_placeholder.cc:183: } Nit: empty line after this ...
3 years, 8 months ago (2017-03-30 09:08:28 UTC) #50
George Joseph
Hello Bernhard, Thanks for the reviewing my change. I have made changes as mentioned in ...
3 years, 8 months ago (2017-03-30 22:58:03 UTC) #51
Bernhard Bauer
https://codereview.chromium.org/2733083004/diff/120001/third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html File third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html (right): https://codereview.chromium.org/2733083004/diff/120001/third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html#newcode6 third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html:6: onerror="errorHandler()"></object> This line should be indented four spaces (similar ...
3 years, 8 months ago (2017-03-31 09:25:21 UTC) #52
George Joseph
Hello Bernhard, Thanks for the review comments. Thanks for being patient with me. I have ...
3 years, 8 months ago (2017-04-03 00:22:34 UTC) #53
Bernhard Bauer
Almost there :) I would also start looking for a Blink reviewer, as I'm not ...
3 years, 8 months ago (2017-04-03 10:14:21 UTC) #54
tommycli
hey, overall with Bernhard's suggestions, I'm satisfied with these changes. lgtm. But like he said ...
3 years, 8 months ago (2017-04-03 22:15:50 UTC) #55
George Joseph
Hello Bernhard and Tommycli, Thanks for the review comments and the LGTM. I have uploaded ...
3 years, 8 months ago (2017-04-04 23:37:41 UTC) #56
Bernhard Bauer
Maybe +jochen could review the Blink side? It's also a bit problematic that there's still ...
3 years, 8 months ago (2017-04-05 09:56:20 UTC) #58
jochen (gone - plz use gerrit)
is it possible to also test that error events aren't dispatched for non-error placeholders?
3 years, 8 months ago (2017-04-05 11:01:37 UTC) #59
groby-ooo-7-16
On 2017/04/05 11:01:37, jochen wrote: > is it possible to also test that error events ...
3 years, 8 months ago (2017-04-05 21:29:14 UTC) #60
George Joseph
-Rachel. Hello Bernhard and Jochen, Thanks for the review comments. I have made the changes ...
3 years, 8 months ago (2017-04-09 00:41:37 UTC) #62
George Joseph
-Rachel. Hello Bernhard and Jochen, Thanks for the review comments. I have made the changes ...
3 years, 8 months ago (2017-04-09 00:41:39 UTC) #63
Bernhard Bauer
https://codereview.chromium.org/2733083004/diff/180001/third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html File third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html (right): https://codereview.chromium.org/2733083004/diff/180001/third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html#newcode7 third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html:7: style="display:none" ></object> This is formatted pretty badly. Please familiarize ...
3 years, 8 months ago (2017-04-09 20:32:25 UTC) #64
jochen (gone - plz use gerrit)
I'll wait for Bernhard to approve, I'm basically happy with that behavior
3 years, 8 months ago (2017-04-10 12:38:34 UTC) #65
George Joseph
Hello Bernhard and jochen, Please find the updated changelist and my comments. Thanks, George. https://codereview.chromium.org/2733083004/diff/180001/third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html ...
3 years, 8 months ago (2017-04-13 11:30:48 UTC) #66
Bernhard Bauer
https://codereview.chromium.org/2733083004/diff/200001/third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html File third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html (right): https://codereview.chromium.org/2733083004/diff/200001/third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html#newcode9 third_party/WebKit/LayoutTests/plugins/object-onerror-placeholder.html:9: " for <object> elements"); Broken lines should be indented ...
3 years, 8 months ago (2017-04-13 15:48:42 UTC) #67
George Joseph
Hello Brenhard, Thanks for the review comments. I have updated the commit as per your ...
3 years, 8 months ago (2017-04-16 18:21:56 UTC) #68
George Joseph
https://codereview.chromium.org/2733083004/diff/200001/third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html File third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html (right): https://codereview.chromium.org/2733083004/diff/200001/third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html#newcode11 third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html:11: testobject.done(); On 2017/04/13 15:48:42, Bernhard Bauer wrote: > Can ...
3 years, 8 months ago (2017-04-16 18:22:29 UTC) #69
Bernhard Bauer
https://codereview.chromium.org/2733083004/diff/220001/third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html File third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html (right): https://codereview.chromium.org/2733083004/diff/220001/third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html#newcode14 third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html:14: setTimeout(function () { I think the timeout is in ...
3 years, 8 months ago (2017-04-18 10:08:02 UTC) #70
George Joseph
Hello Bernhard, Thanks for your review comments. I have made the changes as you have ...
3 years, 8 months ago (2017-04-18 14:18:45 UTC) #71
Bernhard Bauer
https://codereview.chromium.org/2733083004/diff/240001/third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html File third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html (right): https://codereview.chromium.org/2733083004/diff/240001/third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html#newcode11 third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html:11: setTimeout( () => {}, 0); This just posts an ...
3 years, 8 months ago (2017-04-18 14:46:39 UTC) #72
George Joseph
Hello Bernhard, Thanks for the review comments. I have updated the changes as per your ...
3 years, 8 months ago (2017-04-18 15:20:30 UTC) #73
Bernhard Bauer
Almost there :) https://codereview.chromium.org/2733083004/diff/260001/third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html File third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html (right): https://codereview.chromium.org/2733083004/diff/260001/third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html#newcode11 third_party/WebKit/LayoutTests/plugins/object-onload-placeholder.html:11: setTimeout(() => {testobject.done();}, 0); For readability, ...
3 years, 8 months ago (2017-04-18 15:27:03 UTC) #74
George Joseph
Hello Bernhard, Thanks for the comments. Glad to know I am getting there. I have ...
3 years, 8 months ago (2017-04-18 15:33:40 UTC) #75
Bernhard Bauer
LGTM! Moving Joshua to CC as previously mentioned.
3 years, 8 months ago (2017-04-18 15:37:54 UTC) #77
Bernhard Bauer
Hmph, looks like non-l-g-t-m-ing reviewers are sticky :-/
3 years, 8 months ago (2017-04-18 15:40:06 UTC) #78
tommycli
On 2017/04/18 15:37:54, Bernhard Bauer wrote: > LGTM! Moving Joshua to CC as previously mentioned. ...
3 years, 8 months ago (2017-04-18 16:59:31 UTC) #79
George Joseph
On 2017/04/18 16:59:31, tommycli wrote: > On 2017/04/18 15:37:54, Bernhard Bauer wrote: > > LGTM! ...
3 years, 8 months ago (2017-04-18 18:17:42 UTC) #80
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-20 09:43:54 UTC) #82
George Joseph
On 2017/04/20 09:43:54, jochen (slow until May 2) wrote: > lgtm Thanks Joshua. Anyone else ...
3 years, 8 months ago (2017-04-25 13:48:13 UTC) #83
laforge
On 2017/04/25 13:48:13, George Joseph wrote: > On 2017/04/20 09:43:54, jochen (slow until May 2) ...
3 years, 8 months ago (2017-04-25 14:59:28 UTC) #84
waffles
On 2017/04/25 14:59:28, laforge wrote: > On 2017/04/25 13:48:13, George Joseph wrote: > > On ...
3 years, 7 months ago (2017-04-25 19:39:34 UTC) #85
George Joseph
On 2017/04/25 19:39:34, waffles wrote: > On 2017/04/25 14:59:28, laforge wrote: > > On 2017/04/25 ...
3 years, 7 months ago (2017-04-26 23:42:19 UTC) #86
George Joseph
On 2017/04/26 23:42:19, George Joseph wrote: > On 2017/04/25 19:39:34, waffles wrote: > > On ...
3 years, 7 months ago (2017-05-02 10:59:19 UTC) #87
waffles
On 2017/05/02 10:59:19, George Joseph wrote: > On 2017/04/26 23:42:19, George Joseph wrote: > > ...
3 years, 7 months ago (2017-05-02 17:21:06 UTC) #90
George Joseph
On 2017/05/02 17:21:06, waffles wrote: > On 2017/05/02 10:59:19, George Joseph wrote: > > On ...
3 years, 7 months ago (2017-05-03 14:48:15 UTC) #93
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733083004/320001
3 years, 7 months ago (2017-05-03 19:35:21 UTC) #100
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 19:43:24 UTC) #103
Message was sent while issue was closed.
Committed patchset #17 (id:320001) as
https://chromium.googlesource.com/chromium/src/+/f4335e87b019d74e3d8033181019...

Powered by Google App Engine
This is Rietveld 408576698