Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5668)

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.mm

Issue 2727233003: Uses child views in Autofill Popup so we can trigger (Closed)
Patch Set: (int) to NSInteger Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.mm
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.mm b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.mm
index 4de725fe0755917dbc64529cfe9ce8d40eb8950b..9a80047d28bb162b2499a06d77f89dcd7a6560ed 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.mm
@@ -28,7 +28,7 @@ AutofillPopupViewBridge::~AutofillPopupViewBridge() {
[view_ hidePopup];
}
-gfx::Rect AutofillPopupViewBridge::GetRowBounds(size_t index) {
+gfx::Rect AutofillPopupViewBridge::GetRowBounds(int index) {
return controller_->layout_model().GetRowBounds(index);
}
@@ -45,11 +45,19 @@ void AutofillPopupViewBridge::Show() {
[view_ showPopup];
}
-void AutofillPopupViewBridge::InvalidateRow(size_t row) {
- [view_ invalidateRow:row];
+void AutofillPopupViewBridge::OnSelectedRowChanged(
+ base::Optional<int> previous_row_selection,
+ base::Optional<int> current_row_selection) {
+ if (previous_row_selection) {
+ [view_ invalidateRow:*previous_row_selection];
+ }
+
+ if (current_row_selection) {
+ [view_ invalidateRow:*current_row_selection];
+ }
}
-void AutofillPopupViewBridge::UpdateBoundsAndRedrawPopup() {
+void AutofillPopupViewBridge::OnSuggestionsChanged() {
[view_ updateBoundsAndRedrawPopup];
}

Powered by Google App Engine
This is Rietveld 408576698