Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Unified Diff: chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc

Issue 2727233003: Uses child views in Autofill Popup so we can trigger (Closed)
Patch Set: (int) to NSInteger Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc
diff --git a/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc b/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc
index 0a3674885a6957a913890f1b6deb727bd2ac0900..76591fc4ba6149b2ba768e11c7aec3274251d17c 100644
--- a/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc
+++ b/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc
@@ -65,7 +65,7 @@ void AutofillKeyboardAccessoryView::Show() {
env, java_object_, reinterpret_cast<intptr_t>(this),
view_android->GetWindowAndroid()->GetJavaObject());
- UpdateBoundsAndRedrawPopup();
+ OnSuggestionsChanged();
}
void AutofillKeyboardAccessoryView::Hide() {
@@ -74,7 +74,11 @@ void AutofillKeyboardAccessoryView::Hide() {
Java_AutofillKeyboardAccessoryBridge_dismiss(env, java_object_);
}
-void AutofillKeyboardAccessoryView::UpdateBoundsAndRedrawPopup() {
+void AutofillKeyboardAccessoryView::OnSelectedRowChanged(
+ base::Optional<int> previous_row_selection,
+ base::Optional<int> current_row_selection) {}
+
+void AutofillKeyboardAccessoryView::OnSuggestionsChanged() {
JNIEnv* env = base::android::AttachCurrentThread();
size_t count = controller_->GetLineCount();
ScopedJavaLocalRef<jobjectArray> data_array =
@@ -158,9 +162,6 @@ void AutofillKeyboardAccessoryView::ViewDismissed(
delete this;
}
-void AutofillKeyboardAccessoryView::InvalidateRow(size_t) {
-}
-
// static
bool AutofillKeyboardAccessoryView::RegisterAutofillKeyboardAccessoryView(
JNIEnv* env) {

Powered by Google App Engine
This is Rietveld 408576698