Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h

Issue 2718583002: Refactor WebBluetoothServiceClient in the web_bluetooth.mojom (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h
diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h b/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h
index 2c339cc3c7fb21d05a8d8d712912368873a30efc..f57576501886ce4a96b39c0d0032811a30a4f4cf 100644
--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h
+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h
@@ -32,7 +32,6 @@ class ScriptPromiseResolver;
// CallbackPromiseAdapter class comments.
class BluetoothDevice final : public EventTargetWithInlineData,
public ContextLifecycleObserver {
- USING_PRE_FINALIZER(BluetoothDevice, Dispose);
DEFINE_WRAPPERTYPEINFO();
USING_GARBAGE_COLLECTED_MIXIN(BluetoothDevice);
@@ -72,29 +71,14 @@ class BluetoothDevice final : public EventTargetWithInlineData,
// events on navigator.bluetooth and still remain connected even if the
// BluetoothDevice object is garbage collected.
- // USING_PRE_FINALIZER interface.
- // Called before the object gets garbage collected.
- void Dispose();
-
- // ContextLifecycleObserver interface.
- void contextDestroyed(ExecutionContext*) override;
-
- // If gatt is connected then sets gatt.connected to false and disconnects.
- // This function only performs the necessary steps to ensure a device
- // disconnects therefore it should only be used when the object is being
- // garbage collected or the context is being destroyed.
- void DisconnectGATTIfConnected();
-
// Performs necessary cleanup when a device disconnects and fires
// gattserverdisconnected event.
- void CleanupDisconnectedDeviceAndFireEvent();
+ void ClearAttributeInstanceMapAndFireEvent();
// EventTarget methods:
const AtomicString& interfaceName() const override;
ExecutionContext* getExecutionContext() const override;
- void DispatchGattServerDisconnected();
-
Bluetooth* bluetooth() { return m_bluetooth; }
// Interface required by Garbage Collection:

Powered by Google App Engine
This is Rietveld 408576698