third_party/WebKit/Source/core/layout/ScrollAlignment.cpp - Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ScrollAlignment.cpp

Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth. (Closed)

Patch Set: Fixed nits. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ScrollAlignment.cpp

diff --git a/third_party/WebKit/Source/core/layout/ScrollAlignment.cpp b/third_party/WebKit/Source/core/layout/ScrollAlignment.cpp

index b91cd6bdbb8162e2e21c62132d686d95cadb09ba..f9756ff69f9d079bd22a7ccdccef5f90af5a15c0 100644

--- a/third_party/WebKit/Source/core/layout/ScrollAlignment.cpp

+++ b/third_party/WebKit/Source/core/layout/ScrollAlignment.cpp

@@ -59,6 +59,10 @@ const ScrollAlignment ScrollAlignment::kAlignTopAlways = {

kScrollAlignmentTop, kScrollAlignmentTop, kScrollAlignmentTop};

const ScrollAlignment ScrollAlignment::kAlignBottomAlways = {

kScrollAlignmentBottom, kScrollAlignmentBottom, kScrollAlignmentBottom};

+const ScrollAlignment ScrollAlignment::kAlignLeftAlways = {

+ kScrollAlignmentLeft, kScrollAlignmentLeft, kScrollAlignmentLeft};

+const ScrollAlignment ScrollAlignment::kAlignRightAlways = {

+ kScrollAlignmentRight, kScrollAlignmentRight, kScrollAlignmentRight};

#define MIN_INTERSECT_FOR_REVEAL 32