Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrameView.cpp

Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth. (Closed)
Patch Set: Fixed nits. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalFrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalFrameView.cpp b/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
index d73de59408045cbad62d330302496e7b8e58e166..e6981c8f9fe10e780e5801cd31448f6a3a9b6f26 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
@@ -2141,6 +2141,13 @@ PlatformChromeClient* LocalFrameView::GetChromeClient() const {
return &page->GetChromeClient();
}
+SmoothScrollSequencer* LocalFrameView::GetSmoothScrollSequencer() const {
+ Page* page = GetFrame().GetPage();
+ if (!page)
+ return nullptr;
+ return page->GetSmoothScrollSequencer();
+}
+
void LocalFrameView::ContentsResized() {
if (frame_->IsMainFrame() && frame_->GetDocument()) {
if (TextAutosizer* text_autosizer =
@@ -4629,14 +4636,20 @@ bool LocalFrameView::ShouldPlaceVerticalScrollbarOnLeft() const {
LayoutRect LocalFrameView::ScrollIntoView(const LayoutRect& rect_in_content,
const ScrollAlignment& align_x,
const ScrollAlignment& align_y,
+ bool is_smooth,
ScrollType scroll_type) {
LayoutRect view_rect(VisibleContentRect());
LayoutRect expose_rect = ScrollAlignment::GetRectToExpose(
view_rect, rect_in_content, align_x, align_y);
if (expose_rect != view_rect) {
- SetScrollOffset(
- ScrollOffset(expose_rect.X().ToFloat(), expose_rect.Y().ToFloat()),
- scroll_type);
+ ScrollOffset target_offset(expose_rect.X().ToFloat(),
+ expose_rect.Y().ToFloat());
+ if (is_smooth) {
+ DCHECK(scroll_type == kProgrammaticScroll);
+ GetSmoothScrollSequencer()->QueueAnimation(this, target_offset);
+ } else {
+ SetScrollOffset(target_offset, scroll_type);
+ }
}
// Scrolling the LocalFrameView cannot change the input rect's location

Powered by Google App Engine
This is Rietveld 408576698