Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1621)

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollableArea.h

Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth. (Closed)
Patch Set: Change the default setting. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scroll/ScrollableArea.h
diff --git a/third_party/WebKit/Source/platform/scroll/ScrollableArea.h b/third_party/WebKit/Source/platform/scroll/ScrollableArea.h
index a84fe5c645f4d5abb3090b8f4208716afac456f0..728ac9b5de9481f28e3750f2d6f995f0939b591b 100644
--- a/third_party/WebKit/Source/platform/scroll/ScrollableArea.h
+++ b/third_party/WebKit/Source/platform/scroll/ScrollableArea.h
@@ -53,6 +53,7 @@ class ProgrammaticScrollAnimator;
struct ScrollAlignment;
class ScrollAnchor;
class ScrollAnimatorBase;
+class SmoothScrollSequencer;
class CompositorAnimationTimeline;
enum IncludeScrollbarsInRect {
@@ -77,6 +78,10 @@ class PLATFORM_EXPORT ScrollableArea : public GarbageCollectedMixin,
virtual PlatformChromeClient* GetChromeClient() const { return 0; }
+ virtual SmoothScrollSequencer* GetSmoothScrollSequencer() const {
+ return nullptr;
+ }
+
virtual ScrollResult UserScroll(ScrollGranularity, const ScrollOffset&);
virtual void SetScrollOffset(const ScrollOffset&,
@@ -99,6 +104,7 @@ class PLATFORM_EXPORT ScrollableArea : public GarbageCollectedMixin,
virtual LayoutRect ScrollIntoView(const LayoutRect& rect_in_content,
const ScrollAlignment& align_x,
const ScrollAlignment& align_y,
+ bool is_smooth,
ScrollType = kProgrammaticScroll);
static bool ScrollBehaviorFromString(const String&, ScrollBehavior&);
« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollTypes.h ('k') | third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698