third_party/WebKit/Source/core/dom/Element.idl - Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.idl

Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth. (Closed)

Patch Set: Change the default setting. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Element.idl

diff --git a/third_party/WebKit/Source/core/dom/Element.idl b/third_party/WebKit/Source/core/dom/Element.idl

index 47867a1e87d24b59fa69f1a172a5b69207cb357f..b9ea6a7b0216a7ce61fb7d8c2206a81a998c7ee5 100644

--- a/third_party/WebKit/Source/core/dom/Element.idl

+++ b/third_party/WebKit/Source/core/dom/Element.idl

@@ -93,8 +93,8 @@ interface Element : Node {

// return DOMRectList and DOMRect respectively.

ClientRectList getClientRects();

ClientRect getBoundingClientRect();

- // FIXME: scrollIntoView() should have a ScrollIntoViewOptions dictionary argument.

- void scrollIntoView(optional boolean alignWithTop);

+ void scrollIntoView(optional (ScrollIntoViewOptions or boolean)? arg);

[RuntimeEnabled=CSSOMSmoothScroll, ImplementedAs=scrollTo] void scroll(optional ScrollToOptions options);

[RuntimeEnabled=CSSOMSmoothScroll, ImplementedAs=scrollTo] void scroll(unrestricted double x, unrestricted double y);

[RuntimeEnabled=CSSOMSmoothScroll] void scrollTo(optional ScrollToOptions options);