Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2628543003: Check missing headers in the build on CQ (Closed)

Created:
3 years, 11 months ago by wychen
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke, Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Check missing headers in the build on CQ This script is run on the following bots on CQ: - linux_chromium_dbg_ng - linux_chromium_rel_ng Note that this script can only be added to bots that have "all" in "additional_compile_targets". BUG=661774 Review-Url: https://codereview.chromium.org/2628543003 Cr-Commit-Position: refs/heads/master@{#474218} Committed: https://chromium.googlesource.com/chromium/src/+/ded5e27012a9b0d50de4b80a16e024fe5106b160

Patch Set 1 #

Patch Set 2 : update whitelist #

Patch Set 3 : empty whitelist #

Patch Set 4 : remove android bots since they no longer build all #

Total comments: 2

Patch Set 5 : rename whitelist file #

Patch Set 6 : populate whitelist #

Patch Set 7 : check removed headers as well #

Patch Set 8 : rebase and fixup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+442 lines, -1 line) Patch
M build/check_gn_headers.py View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
A build/check_gn_headers_whitelist.txt View 1 2 3 4 5 6 1 chunk +386 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 3 4 5 6 7 2 chunks +8 lines, -0 lines 0 comments Download
A testing/scripts/check_gn_headers.py View 1 2 3 4 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (16 generated)
wychen
PTAL. After the optimization in https://codereview.chromium.org/2846473002 , the time spent in this step is much ...
3 years, 7 months ago (2017-05-19 16:20:23 UTC) #6
Nico
I'll leave this to Dirk. https://codereview.chromium.org/2628543003/diff/80001/testing/scripts/check_gn_headers.py File testing/scripts/check_gn_headers.py (right): https://codereview.chromium.org/2628543003/diff/80001/testing/scripts/check_gn_headers.py#newcode22 testing/scripts/check_gn_headers.py:22: os.path.join(common.SRC_DIR, 'build', 'gn_missing_headers.txt'), either ...
3 years, 7 months ago (2017-05-19 19:20:38 UTC) #7
wychen
https://codereview.chromium.org/2628543003/diff/80001/testing/scripts/check_gn_headers.py File testing/scripts/check_gn_headers.py (right): https://codereview.chromium.org/2628543003/diff/80001/testing/scripts/check_gn_headers.py#newcode22 testing/scripts/check_gn_headers.py:22: os.path.join(common.SRC_DIR, 'build', 'gn_missing_headers.txt'), On 2017/05/19 19:20:38, Nico wrote: > ...
3 years, 7 months ago (2017-05-22 21:17:15 UTC) #8
Dirk Pranke
lgtm
3 years, 7 months ago (2017-05-23 20:40:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628543003/160001
3 years, 7 months ago (2017-05-24 04:52:24 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/434949)
3 years, 7 months ago (2017-05-24 05:56:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628543003/160001
3 years, 7 months ago (2017-05-24 06:54:34 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/434998)
3 years, 7 months ago (2017-05-24 07:41:54 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628543003/160001
3 years, 7 months ago (2017-05-24 07:54:29 UTC) #22
commit-bot: I haz the power
Committed patchset #8 (id:160001) as https://chromium.googlesource.com/chromium/src/+/ded5e27012a9b0d50de4b80a16e024fe5106b160
3 years, 7 months ago (2017-05-24 08:57:27 UTC) #25
vitaliii
3 years, 7 months ago (2017-05-24 12:02:43 UTC) #26
Message was sent while issue was closed.
A revert of this CL (patchset #8 id:160001) has been created in
https://codereview.chromium.org/2900143004/ by vitaliii@chromium.org.

The reason for reverting is: This CL likely breaks |check_gn_headers| step. See
crbug.com/725877 for details..

Powered by Google App Engine
This is Rietveld 408576698