Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc

Issue 2407143002: Remove GetFeedbackInterval in sender side BWE. (Closed)
Patch Set: Respond to comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 TEST_F(DelayBasedBweTest, GetExpectedBwePeriodMs) { 133 TEST_F(DelayBasedBweTest, GetExpectedBwePeriodMs) {
134 int64_t default_interval_ms = bitrate_estimator_->GetExpectedBwePeriodMs(); 134 int64_t default_interval_ms = bitrate_estimator_->GetExpectedBwePeriodMs();
135 EXPECT_GT(default_interval_ms, 0); 135 EXPECT_GT(default_interval_ms, 0);
136 CapacityDropTestHelper(1, true, 333, 0); 136 CapacityDropTestHelper(1, true, 333, 0);
137 int64_t interval_ms = bitrate_estimator_->GetExpectedBwePeriodMs(); 137 int64_t interval_ms = bitrate_estimator_->GetExpectedBwePeriodMs();
138 EXPECT_GT(interval_ms, 0); 138 EXPECT_GT(interval_ms, 0);
139 EXPECT_NE(interval_ms, default_interval_ms); 139 EXPECT_NE(interval_ms, default_interval_ms);
140 } 140 }
141 141
142 TEST_F(DelayBasedBweTest, InitialBehavior) { 142 TEST_F(DelayBasedBweTest, InitialBehavior) {
143 InitialBehaviorTestHelper(674840); 143 InitialBehaviorTestHelper(730000);
144 } 144 }
145 145
146 TEST_F(DelayBasedBweTest, RateIncreaseReordering) { 146 TEST_F(DelayBasedBweTest, RateIncreaseReordering) {
147 RateIncreaseReorderingTestHelper(674840); 147 RateIncreaseReorderingTestHelper(730000);
148 } 148 }
149 TEST_F(DelayBasedBweTest, RateIncreaseRtpTimestamps) { 149 TEST_F(DelayBasedBweTest, RateIncreaseRtpTimestamps) {
150 RateIncreaseRtpTimestampsTestHelper(1288); 150 RateIncreaseRtpTimestampsTestHelper(627);
151 } 151 }
152 152
153 TEST_F(DelayBasedBweTest, CapacityDropOneStream) { 153 TEST_F(DelayBasedBweTest, CapacityDropOneStream) {
154 CapacityDropTestHelper(1, false, 333, 0); 154 CapacityDropTestHelper(1, false, 300, 0);
155 } 155 }
156 156
157 TEST_F(DelayBasedBweTest, CapacityDropPosOffsetChange) { 157 TEST_F(DelayBasedBweTest, CapacityDropPosOffsetChange) {
158 CapacityDropTestHelper(1, false, 867, 30000); 158 CapacityDropTestHelper(1, false, 867, 30000);
159 } 159 }
160 160
161 TEST_F(DelayBasedBweTest, CapacityDropNegOffsetChange) { 161 TEST_F(DelayBasedBweTest, CapacityDropNegOffsetChange) {
162 CapacityDropTestHelper(1, false, 867, -30000); 162 CapacityDropTestHelper(1, false, 933, -30000);
163 } 163 }
164 164
165 TEST_F(DelayBasedBweTest, CapacityDropOneStreamWrap) { 165 TEST_F(DelayBasedBweTest, CapacityDropOneStreamWrap) {
166 CapacityDropTestHelper(1, true, 333, 0); 166 CapacityDropTestHelper(1, true, 333, 0);
167 } 167 }
168
168 TEST_F(DelayBasedBweTest, TestTimestampGrouping) { 169 TEST_F(DelayBasedBweTest, TestTimestampGrouping) {
169 TestTimestampGroupingTestHelper(); 170 TestTimestampGroupingTestHelper();
170 } 171 }
171 172
172 TEST_F(DelayBasedBweTest, TestShortTimeoutAndWrap) { 173 TEST_F(DelayBasedBweTest, TestShortTimeoutAndWrap) {
173 // Simulate a client leaving and rejoining the call after 35 seconds. This 174 // Simulate a client leaving and rejoining the call after 35 seconds. This
174 // will make abs send time wrap, so if streams aren't timed out properly 175 // will make abs send time wrap, so if streams aren't timed out properly
175 // the next 30 seconds of packets will be out of order. 176 // the next 30 seconds of packets will be out of order.
176 TestWrappingHelper(35); 177 TestWrappingHelper(35);
177 } 178 }
178 179
179 TEST_F(DelayBasedBweTest, TestLongTimeoutAndWrap) { 180 TEST_F(DelayBasedBweTest, TestLongTimeoutAndWrap) {
180 // Simulate a client leaving and rejoining the call after some multiple of 181 // Simulate a client leaving and rejoining the call after some multiple of
181 // 64 seconds later. This will cause a zero difference in abs send times due 182 // 64 seconds later. This will cause a zero difference in abs send times due
182 // to the wrap, but a big difference in arrival time, if streams aren't 183 // to the wrap, but a big difference in arrival time, if streams aren't
183 // properly timed out. 184 // properly timed out.
184 TestWrappingHelper(10 * 64); 185 TestWrappingHelper(10 * 64);
185 } 186 }
186 187
187 } // namespace webrtc 188 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698