Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

Issue 2236193002: WIP: Implement CSS transitions on top of InterpolationTypes instead of AnimatableValues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_environmentStyle
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/svg/SVGElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
index b160cb46c5c1eb22c09a7a501c3a0b600073e33f..b2f7162850a43996cf4310abd719ad99afbb1518 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
@@ -35,8 +35,8 @@
#include "core/animation/AnimationTimeline.h"
#include "core/animation/ElementAnimations.h"
#include "core/animation/InterpolationEnvironment.h"
-#include "core/animation/InvalidatableInterpolation.h"
#include "core/animation/KeyframeEffect.h"
+#include "core/animation/StackableInterpolation.h"
#include "core/animation/StyleInterpolation.h"
#include "core/animation/animatable/AnimatableValue.h"
#include "core/animation/css/CSSAnimatableValueFactory.h"
@@ -1177,12 +1177,12 @@ void StyleResolver::applyAnimatedProperties(StyleResolverState& state, const Act
if (!CSSPropertyPriorityData<priority>::propertyHasPriority(property))
continue;
const Interpolation& interpolation = *entry.value.first();
- if (interpolation.isInvalidatableInterpolation()) {
- InterpolationEnvironment environment(state);
- InvalidatableInterpolation::applyStack(entry.value, environment);
- } else {
+ if (interpolation.isStyleInterpolation()) {
// TODO(alancutter): Remove this old code path once animations have completely migrated to InterpolationTypes.
toStyleInterpolation(interpolation).apply(state);
+ } else {
+ InterpolationEnvironment environment(state);
+ StackableInterpolation::applyStack(entry.value, environment);
}
}
}
« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/svg/SVGElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698