third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h - Issue 2236193002: WIP: Implement CSS transitions on top of InterpolationTypes instead of AnimatableValues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h

Issue 2236193002: WIP: Implement CSS transitions on top of InterpolationTypes instead of AnimatableValues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_environmentStyle

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/TypedInterpolationValue.h ('k') | third_party/WebKit/Source/core/animation/css/CSSAnimations.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h

diff --git a/third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h b/third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h

index c1920e4841c629f5f6a230532ba108e97e4c223b..0abd431246965b9334d58d2d0a1e1c1616cdf720 100644

--- a/third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h

+++ b/third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h

@@ -152,7 +152,7 @@ public:

m_updatedCompositorKeyframes.append(animation);

}

- void startTransition(CSSPropertyID id, const AnimatableValue* from, const AnimatableValue* to, PassRefPtr<AnimatableValue> reversingAdjustedStartValue, double reversingShorteningFactor, const InertEffect& effect)

+ void startTransition(CSSPropertyID id, PassRefPtr<AnimatableValue> from, PassRefPtr<AnimatableValue> to, PassRefPtr<AnimatableValue> reversingAdjustedStartValue, double reversingShorteningFactor, const InertEffect& effect)

{

NewTransition newTransition;

newTransition.id = id;

@@ -183,8 +183,8 @@ public:

}

CSSPropertyID id;

- const AnimatableValue* from;

- const AnimatableValue* to;

+ RefPtr<AnimatableValue> from;

+ RefPtr<AnimatableValue> to;

RefPtr<AnimatableValue> reversingAdjustedStartValue;

double reversingShorteningFactor;

Member<const InertEffect> effect;