chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java - Issue 2005623002: Logic for the Data Saver InfoBar Promo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java

Issue 2005623002: Logic for the Data Saver InfoBar Promo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: missing returns Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/firstrun/DataReductionProxyFirstRunFragment.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java

index 190e90ab6825b87fc8ef11cf9106ef4c085fb6d4..bace63698f28cd4256235a0ab1e8f3294c652de3 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java

@@ -25,7 +25,7 @@ import org.chromium.chrome.browser.EmbedContentViewActivity;

import org.chromium.chrome.browser.init.ChromeBrowserInitializer;

import org.chromium.chrome.browser.metrics.UmaUtils;

import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;

-import org.chromium.chrome.browser.preferences.datareduction.DataReductionPromoScreen;

+import org.chromium.chrome.browser.preferences.datareduction.DataReductionPromoUtils;

import org.chromium.chrome.browser.preferences.datareduction.DataReductionProxyUma;

import org.chromium.chrome.browser.profiles.Profile;

import org.chromium.chrome.browser.signin.SigninAccessPoint;

@@ -301,18 +301,15 @@ public class FirstRunActivity extends AppCompatActivity implements FirstRunPageD

mFreProperties.putBoolean(RESULT_SHOW_SIGNIN_SETTINGS, mResultShowSignInSettings);

FirstRunFlowSequencer.markFlowAsCompleted(this, mFreProperties);

- if (DataReductionPromoScreen

- .getDisplayedDataReductionPromo(getApplicationContext())) {

+ if (DataReductionPromoUtils.getDisplayedFreOrSecondRunPromo()) {

if (DataReductionProxySettings.getInstance().isDataReductionProxyEnabled()) {

DataReductionProxyUma

.dataReductionProxyUIAction(DataReductionProxyUma.ACTION_FRE_ENABLED);

- DataReductionPromoScreen

- .saveDataReductionFrePromoOptOut(getApplicationContext(), false);

+ DataReductionPromoUtils.saveFrePromoOptOut(false);

} else {

DataReductionProxyUma

.dataReductionProxyUIAction(DataReductionProxyUma.ACTION_FRE_DISABLED);

- DataReductionPromoScreen

- .saveDataReductionFrePromoOptOut(getApplicationContext(), true);

+ DataReductionPromoUtils.saveFrePromoOptOut(true);

}