third_party/WebKit/Source/core/animation/CompositorAnimations.cpp - Issue 1850433003: [WIP] Use InterpolationTypes for CSS Transitions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CompositorAnimations.cpp

Issue 1850433003: [WIP] Use InterpolationTypes for CSS Transitions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/AnimationStack.cpp ('k') | third_party/WebKit/Source/core/animation/DeferredLegacyStyleInterpolation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CompositorAnimations.cpp

diff --git a/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp b/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp

index b885962f2d512d384c35974222a39ce34f10d6e3..14e68c9873e97f8b715fe9516bc6f77187d1c897 100644

--- a/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp

+++ b/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp

@@ -225,6 +225,10 @@ bool CompositorAnimations::getAnimatedBoundingBox(FloatBox& box, const EffectMod

bool CompositorAnimations::isCandidateForAnimationOnCompositor(const Timing& timing, const Element& targetElement, const Animation* animationToAdd, const EffectModel& effect, double animationPlaybackRate)

{

+ // TODO(alancutter): Make transitions work on the compositor

+ if (!effect.isKeyframeEffectModel())

+ return false;

const KeyframeEffectModelBase& keyframeEffect = toKeyframeEffectModelBase(effect);

PropertyHandleSet properties = keyframeEffect.properties();